Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: net/quic/quic_connection_test.cc

Issue 876313009: Keep an instance of QuicAckFrame in QuicConnection in order to reduce (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fix_compile_errors_85182632
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_packet_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 091dc9ec86df1633ed9a77efbb0ea3c93a1e5618..47588d0f060e0ac7475b3d8d79430ffc3e38d905 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -662,14 +662,13 @@ class QuicConnectionTest : public ::testing::TestWithParam<QuicVersion> {
}
QuicAckFrame* outgoing_ack() {
- outgoing_ack_.reset(QuicConnectionPeer::CreateAckFrame(&connection_));
- return outgoing_ack_.get();
+ QuicConnectionPeer::PopulateAckFrame(&connection_, &ack_);
+ return &ack_;
}
QuicStopWaitingFrame* stop_waiting() {
- stop_waiting_.reset(
- QuicConnectionPeer::CreateStopWaitingFrame(&connection_));
- return stop_waiting_.get();
+ QuicConnectionPeer::PopulateStopWaitingFrame(&connection_, &stop_waiting_);
+ return &stop_waiting_;
}
QuicPacketSequenceNumber least_unacked() {
@@ -1006,8 +1005,8 @@ class QuicConnectionTest : public ::testing::TestWithParam<QuicVersion> {
QuicPacketHeader header_;
QuicStreamFrame frame1_;
QuicStreamFrame frame2_;
- scoped_ptr<QuicAckFrame> outgoing_ack_;
- scoped_ptr<QuicStopWaitingFrame> stop_waiting_;
+ QuicAckFrame ack_;
+ QuicStopWaitingFrame stop_waiting_;
QuicSequenceNumberLength sequence_number_length_;
QuicConnectionIdLength connection_id_length_;
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_packet_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698