Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/event_test.cc

Issue 875543002: Grab a bunch of owners / todos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tests/nacl_io_test/event_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/event_test.cc b/native_client_sdk/src/tests/nacl_io_test/event_test.cc
index 8084df0732a7f45e2355ed9d645f29f09fae1871..f85f9e2cb92b41494b223ef43b64cb8a847af132 100644
--- a/native_client_sdk/src/tests/nacl_io_test/event_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/event_test.cc
@@ -290,7 +290,7 @@ TEST_F(SelectPollTest, PollMemPipe) {
SetFDs(fds, 2);
ASSERT_EQ(2, kp->poll(pollfds, 2, 0));
- // TODO(noelallen) fix poll based on open mode
+ // TODO(bradnelson) fix poll based on open mode
// EXPECT_EQ(0, pollfds[0].revents);
// Bug 291018
ASSERT_EQ(POLLOUT, pollfds[1].revents);
@@ -325,7 +325,7 @@ TEST_F(SelectPollTest, SelectMemPipe) {
ASSERT_EQ(2, kp->select(fds[1] + 1, &rd_set, &wr_set, &ex_set, &tv));
EXPECT_EQ(0, FD_ISSET(fds[0], &rd_set));
EXPECT_EQ(0, FD_ISSET(fds[1], &rd_set));
- // TODO(noelallen) fix poll based on open mode
+ // TODO(bradnelson) fix poll based on open mode
// EXPECT_EQ(0, FD_ISSET(fds[0], &wr_set));
// Bug 291018
EXPECT_NE(0, FD_ISSET(fds[1], &wr_set));
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc ('k') | native_client_sdk/src/tools/lib/get_shared_deps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698