native_client_sdk/src/tools/lib/get_shared_deps.py - Issue 875543002: Grab a bunch of owners / todos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/lib/get_shared_deps.py

Issue 875543002: Grab a bunch of owners / todos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tools/lib/get_shared_deps.py

diff --git a/native_client_sdk/src/tools/lib/get_shared_deps.py b/native_client_sdk/src/tools/lib/get_shared_deps.py

index b7b433f1d5b2671023f35be33b025cb41b818a01..7a355cadc2e569aa5f583c3d9d8f0467269c3ac3 100644

--- a/native_client_sdk/src/tools/lib/get_shared_deps.py

+++ b/native_client_sdk/src/tools/lib/get_shared_deps.py

@@ -211,7 +211,7 @@ def _FindLibsInPath(name, lib_path):

# the SONAME is actually libc.so. If we pass glibc's libc.so to objdump

# if fails to parse it, os this filters out libc.so expept for within

# the bionic toolchain.

- # TODO(noelallen): Remove this once the SONAME in bionic is made to be

+ # TODO(bradnelson): Remove this once the SONAME in bionic is made to be

# unique in the same it is under glibc:

# https://code.google.com/p/nativeclient/issues/detail?id=3833

rel_dirname = os.path.relpath(dirname, SDK_DIR)

« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/event_test.cc ('k') | ppapi/generators/OWNERS » ('j') | no next file with comments »