native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc - Issue 875543002: Grab a bunch of owners / todos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

Issue 875543002: Grab a bunch of owners / todos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc b/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

index 95cc4f35ba77f2a87fe52e6dd89de4b4c922218e..4eaf6ac6db83da826254d5565985d157129d4bf8 100644

--- a/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

+++ b/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc

@@ -364,7 +364,7 @@ Error SocketNode::RecvHelper(const HandleAttr& attr,

if ((flags & MSG_DONTWAIT) || !attr.IsBlocking())

ms = 0;

- // TODO(noelallen) BUG=295177

+ // TODO(bradnelson) BUG=295177

// For UDP we should support filtering packets when using connect

EventListenerLock wait(GetEventEmitter());

Error err = wait.WaitOnEvent(POLLIN, ms);