Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 875263004: [turbofan] Ensure that NTLs are always properly connected to the end. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure that NTLs are always properly connected to the end. Up until now we used a special Terminate node to artifically connect non terminating loops to the End node, but this was kind of adhoc and didn't work for the CFG. So without all kinds of weird hacks, the end block in the CFG will not be connected to NTLs, which makes it impossible to compute post dominance / control dependence in the current setting. So instead of Terminate, we add a special Branch to NTLs, whose condition is the special Always node, which corresponds to True, except that it cannot be folded away. This way we don't need any special machinery in the scheduler, since it's just a regular Branch. R=titzer@chromium.org Committed: https://crrev.com/59a02ebdbeb6594a596cd61a380841e3c4bc9851 Cr-Commit-Position: refs/heads/master@{#26294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -255 lines) Patch
M src/compiler/common-operator.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/control-reducer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/control-reducer.cc View 2 chunks +67 lines, -24 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/scheduler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 3 chunks +16 lines, -13 lines 0 comments Download
A test/unittests/compiler/control-reducer-unittest.cc View 1 chunk +124 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +48 lines, -0 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-27 13:32:39 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-27 13:33:07 UTC) #3
titzer
lgtm
5 years, 11 months ago (2015-01-27 13:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875263004/1
5 years, 11 months ago (2015-01-27 13:56:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 14:02:28 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 14:02:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59a02ebdbeb6594a596cd61a380841e3c4bc9851
Cr-Commit-Position: refs/heads/master@{#26294}

Powered by Google App Engine
This is Rietveld 408576698