Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: test/unittests/compiler/scheduler-unittest.cc

Issue 875263004: [turbofan] Ensure that NTLs are always properly connected to the end. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/node-test-utils.cc ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/scheduler-unittest.cc
diff --git a/test/unittests/compiler/scheduler-unittest.cc b/test/unittests/compiler/scheduler-unittest.cc
index 6ce9d4293bc07679d90c1d5daf96984eda3ec090..e966acae2f40360dc0d82dc8a656544713d26755 100644
--- a/test/unittests/compiler/scheduler-unittest.cc
+++ b/test/unittests/compiler/scheduler-unittest.cc
@@ -1966,29 +1966,6 @@ TARGET_TEST_F(SchedulerTest, BranchHintFalse) {
CHECK(!schedule->block(f)->deferred());
}
-
-TARGET_TEST_F(SchedulerTest, ScheduleTerminate) {
- Node* start = graph()->NewNode(common()->Start(1));
- graph()->SetStart(start);
-
- Node* loop = graph()->NewNode(common()->Loop(2), start, start);
- loop->ReplaceInput(1, loop); // self loop, NTL.
-
- Node* effect = graph()->NewNode(common()->EffectPhi(1), start, loop);
- effect->ReplaceInput(0, effect);
-
- Node* terminate = graph()->NewNode(common()->Terminate(1), effect, loop);
- Node* end = graph()->NewNode(common()->End(), terminate);
-
- graph()->SetEnd(end);
-
- Schedule* schedule = ComputeAndVerifySchedule(6, graph());
- BasicBlock* block = schedule->block(loop);
- CHECK_NE(NULL, loop);
- CHECK_EQ(block, schedule->block(effect));
- CHECK_GE(block->rpo_number(), 0);
-}
-
} // namespace compiler
} // namespace internal
} // namespace v8
« no previous file with comments | « test/unittests/compiler/node-test-utils.cc ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698