Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 874613002: Don't share Push API message payloads unless explicitly enabled. (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't share Push API message payloads unless explicitly enabled. There are open security issues about exposing payloads for the Push API, so we'd like to guard those behind a command line flag for now. This is part of a three-sided patch: [1] https://codereview.chromium.org/872013002 [2] This patch. [3] https://codereview.chromium.org/869303002 BUG=449184 Committed: https://crrev.com/454b4e532e491f2582029994ae263623ae58317d Cr-Commit-Position: refs/heads/master@{#313265}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 3 chunks +35 lines, -23 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
+mvanouwerkerk for the Push API I'll poke a content/ owner after you're happy.
5 years, 11 months ago (2015-01-23 18:21:05 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 11 months ago (2015-01-23 18:35:14 UTC) #3
Peter Beverloo
+avi for new command line flag
5 years, 11 months ago (2015-01-26 14:32:53 UTC) #5
Avi (use Gerrit)
lgtm The flag is fine. You are planning on eventually removing it?
5 years, 11 months ago (2015-01-26 15:27:01 UTC) #6
Peter Beverloo
On 2015/01/26 15:27:01, Avi (OOO 18-25 Jan) wrote: > lgtm > > The flag is ...
5 years, 11 months ago (2015-01-26 15:29:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874613002/20001
5 years, 11 months ago (2015-01-27 13:06:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 13:13:25 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 13:14:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/454b4e532e491f2582029994ae263623ae58317d
Cr-Commit-Position: refs/heads/master@{#313265}

Powered by Google App Engine
This is Rietveld 408576698