Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 872013002: Separate push event data from the rest of the W3C Push API flag. (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 11 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Separate push event data from the rest of the W3C Push API flag. Supporting payloads for incoming push messages is blocked on resolving a number of security concerns, key in which is enforcing encryption as part of the W3C Push API. Not exposing the "data" attribute and the PushMessageData object for PushEvents is the best option for now, which allows developers to feature detect support for payloads. Availability of the payloads will be toggled by the embedder. This is part of a three-sided patch: [1] This patch. [2] https://codereview.chromium.org/874613002 [3] https://codereview.chromium.org/869303002 BUG=449184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188932

Patch Set 1 #

Patch Set 2 : expose the ability to toggle the flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M Source/modules/push_messaging/PushEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushMessageData.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
+mvanouwerkerk for Push API +mkwst for the runtime feature
5 years, 11 months ago (2015-01-23 18:20:40 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 11 months ago (2015-01-23 18:23:44 UTC) #3
Mike West
lgtm
5 years, 11 months ago (2015-01-23 19:03:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872013002/20001
5 years, 11 months ago (2015-01-24 18:17:47 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 18:20:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188932

Powered by Google App Engine
This is Rietveld 408576698