Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 869303002: Change the PushMessagingData runtime feature to be "test". (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change the PushMessagingData runtime feature to be "test". The embedder can separately enable this if they so desire, but meanwhile we don't want the test coverage for the feature to rot either. This is part of a three-sided patch: [1] https://codereview.chromium.org/872013002 [2] https://codereview.chromium.org/874613002 [3] This patch. BUG=449184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
+mvanouwerkerk, mkwst
5 years, 11 months ago (2015-01-23 18:21:26 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 11 months ago (2015-01-23 18:24:13 UTC) #3
Mike West
LGTM.
5 years, 11 months ago (2015-01-26 10:05:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869303002/1
5 years, 10 months ago (2015-01-27 17:06:24 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 17:19:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189040

Powered by Google App Engine
This is Rietveld 408576698