Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 873923003: sky/shell should link with sky/engine (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

sky/shell should link with sky/engine This CL causes sky/shell to create a blink::WebView to show that sky/shell links with sky/engine. In the process, I've made it easier to be a trivial embedder of sky/engine by removing the requirement to implement blink::ServiceProvider. This CL also causes sky/shell to link with mojo/edk/system to resolve link errors with Mojo fabric (e.g., MojoClose, MojoWriteMessage, etc). To make this work properly, we'll need to initialize the EDK in a future CL. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c122059c0b73f781f47cead2078df0bc970e1409

Patch Set 1 #

Total comments: 3

Patch Set 2 : moar deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -22 lines) Patch
M sky/engine/core/frame/FrameHost.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/ServiceProvider.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/BUILD.gn View 1 2 chunks +7 lines, -2 lines 0 comments Download
M sky/shell/shell.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/shell/shell.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/shell/sky_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A sky/shell/ui/engine.h View 1 chunk +40 lines, -0 lines 0 comments Download
A sky/shell/ui/engine.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A sky/shell/ui/platform_impl.h View 1 chunk +32 lines, -0 lines 0 comments Download
A sky/shell/ui/platform_impl.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-04 07:27:57 UTC) #1
eseidel
lgtm https://codereview.chromium.org/873923003/diff/1/sky/engine/core/html/HTMLAnchorElement.cpp File sky/engine/core/html/HTMLAnchorElement.cpp (right): https://codereview.chromium.org/873923003/diff/1/sky/engine/core/html/HTMLAnchorElement.cpp#newcode120 sky/engine/core/html/HTMLAnchorElement.cpp:120: host->services()->NavigatorHost()->RequestNavigate( Servics can be null now, do you ...
5 years, 10 months ago (2015-02-04 08:23:58 UTC) #2
abarth-chromium
https://codereview.chromium.org/873923003/diff/1/sky/engine/core/html/HTMLAnchorElement.cpp File sky/engine/core/html/HTMLAnchorElement.cpp (right): https://codereview.chromium.org/873923003/diff/1/sky/engine/core/html/HTMLAnchorElement.cpp#newcode120 sky/engine/core/html/HTMLAnchorElement.cpp:120: host->services()->NavigatorHost()->RequestNavigate( On 2015/02/04 at 08:23:58, eseidel wrote: > Servics ...
5 years, 10 months ago (2015-02-04 16:40:06 UTC) #3
eseidel
lgtm
5 years, 10 months ago (2015-02-04 18:19:03 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-02-05 03:31:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c122059c0b73f781f47cead2078df0bc970e1409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698