Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: sky/engine/core/frame/FrameHost.h

Issue 873923003: sky/shell should link with sky/engine (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: moar deps Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameHost.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // FrameHost currently corresponds to the Page object in core/page 48 // FrameHost currently corresponds to the Page object in core/page
49 // however the concept of a Page is moving up out of Blink. 49 // however the concept of a Page is moving up out of Blink.
50 // In an out-of-process iframe world, a single Page may have 50 // In an out-of-process iframe world, a single Page may have
51 // multiple frames in different process, thus Page becomes a 51 // multiple frames in different process, thus Page becomes a
52 // browser-level concept and Blink core/ only knows about its LocalFrame (and Fr ameHost). 52 // browser-level concept and Blink core/ only knows about its LocalFrame (and Fr ameHost).
53 // Separating Page from the rest of core/ through this indirection 53 // Separating Page from the rest of core/ through this indirection
54 // allows us to slowly refactor Page without breaking the rest of core. 54 // allows us to slowly refactor Page without breaking the rest of core.
55 class FrameHost final { 55 class FrameHost final {
56 WTF_MAKE_NONCOPYABLE(FrameHost); WTF_MAKE_FAST_ALLOCATED; 56 WTF_MAKE_NONCOPYABLE(FrameHost); WTF_MAKE_FAST_ALLOCATED;
57 public: 57 public:
58 static PassOwnPtr<FrameHost> create(Page&, ServiceProvider&); 58 static PassOwnPtr<FrameHost> create(Page&, ServiceProvider*);
59 ~FrameHost(); 59 ~FrameHost();
60 60
61 // Careful: This function will eventually be removed. 61 // Careful: This function will eventually be removed.
62 Page& page() const { return *m_page; } 62 Page& page() const { return *m_page; }
63 Settings& settings() const; 63 Settings& settings() const;
64 64
65 ServiceProvider& services() const { return m_services; } 65 ServiceProvider* services() const { return m_services; }
66 66
67 // Corresponds to pixel density of the device where this Page is 67 // Corresponds to pixel density of the device where this Page is
68 // being displayed. In multi-monitor setups this can vary between pages. 68 // being displayed. In multi-monitor setups this can vary between pages.
69 // This value does not account for Page zoom, use LocalFrame::devicePixelRat io instead. 69 // This value does not account for Page zoom, use LocalFrame::devicePixelRat io instead.
70 float deviceScaleFactor() const; 70 float deviceScaleFactor() const;
71 71
72 private: 72 private:
73 FrameHost(Page&, ServiceProvider&); 73 FrameHost(Page&, ServiceProvider*);
74 74
75 Page* m_page; 75 Page* m_page;
76 ServiceProvider& m_services; 76 ServiceProvider* m_services;
77 }; 77 };
78 78
79 } 79 }
80 80
81 #endif // SKY_ENGINE_CORE_FRAME_FRAMEHOST_H_ 81 #endif // SKY_ENGINE_CORE_FRAME_FRAMEHOST_H_
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698