sky/engine/core/html/HTMLAnchorElement.cpp - Issue 873923003: sky/shell should link with sky/engine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/html/HTMLAnchorElement.cpp

Issue 873923003: sky/shell should link with sky/engine (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « sky/engine/core/frame/FrameHost.cpp ('k') | sky/engine/core/page/Page.h » ('j') | sky/shell/ui/engine.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Simon Hausmann <hausmann@kde.org>	4 * (C) 2000 Simon Hausmann <hausmann@kde.org>

5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.	5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.

6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)	6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 99 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
110 void HTMLAnchorElement::handleClick(Event* event)	110 void HTMLAnchorElement::handleClick(Event* event)

111 {	111 {

112 Frame* frame = document().frame();	112 Frame* frame = document().frame();

113 if (!frame)	113 if (!frame)

114 return;	114 return;

115 FrameHost* host = frame->host();	115 FrameHost* host = frame->host();

116 if (!host)	116 if (!host)

117 return;	117 return;

118 mojo::URLRequestPtr request = mojo::URLRequest::New();	118 mojo::URLRequestPtr request = mojo::URLRequest::New();

119 request->url = href().string().toUTF8();	119 request->url = href().string().toUTF8();

120 host->services().NavigatorHost()->RequestNavigate(	120 host->services()->NavigatorHost()->RequestNavigate(
	eseidel 2015/02/04 08:23:58 Servics can be null now, do you want to crash here Servics can be null now, do you want to crash here? abarth-chromium 2015/02/04 16:40:05 I think that's ok for now. We'll probably need to Show quoted text On 2015/02/04 at 08:23:58, eseidel wrote: > Servics can be null now, do you want to crash here? I think that's ok for now. We'll probably need to do something smarter at some point.
121 mojo::TARGET_SOURCE_NODE, request.Pass());	121 mojo::TARGET_SOURCE_NODE, request.Pass());

122 event->setDefaultHandled();	122 event->setDefaultHandled();

123 }	123 }

124	124

125 }	125 }

OLD	NEW