Set serial connection parameters immediately on connect.

Set serial connection parameters immediately on connect.

This change merges the initial call to SetCommState/tcsetattr with
the call to ConfigurePort so that parameters such as baud rate are
configured immediately when the port is opened. Default values for
these parameters are now always applied.

This works around an issue with some serial adapter drivers on Windows
that report an invalid baud rate through GetCommState. Having the
intended baud rate available for the first call to SetCommState allows
an application to provide a valid value so that Chrome does not have
to guess.

BUG=448407
Committed: https://crrev.com/ea2760c173e70ddcdcc64e0522a93d6a08785cae
Cr-Commit-Position: refs/heads/master@{#313604}

[Reilly Grant (use Gerrit), 2015-01-26 21:41:05]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-01-26 21:41:36]

Ken, this patch ended up being a little more involved than I planned. Please
take a look.

[Ken Rockot(use gerrit already), 2015-01-28 19:22:11]

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
File extensions/renderer/api/serial/serial_api_unittest.cc (right):

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
extensions/renderer/api/serial/serial_api_unittest.cc:192:
device::serial::DATA_BITS_SEVEN,  // set
what is all this "  // set" notation

[Reilly Grant (use Gerrit), 2015-01-28 21:00:09]

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
File extensions/renderer/api/serial/serial_api_unittest.cc (right):

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
extensions/renderer/api/serial/serial_api_unittest.cc:192:
device::serial::DATA_BITS_SEVEN,  // set
On 2015/01/28 19:22:10, Ken Rockot wrote:
> what is all this "  // set" notation

In the original test because the unmodified options where not passed to
ConfigurePort they would have their default values. Now that they have their
previous values I thought it would improve readability to make it clear which
value was actually changed in each test case.

[Ken Rockot(use gerrit already), 2015-01-28 21:25:34]

ok - lgtm but please document above the tests what the significance of "set" is

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
File extensions/renderer/api/serial/serial_api_unittest.cc (right):

https://codereview.chromium.org/873903002/diff/20001/extensions/renderer/api/...
extensions/renderer/api/serial/serial_api_unittest.cc:186:
GenerateConnectionOptions(57600, // set
nit: two spaces before //

[Reilly Grant (use Gerrit), 2015-01-28 22:08:29]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2015-01-28 22:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873903002/40001

[commit-bot: I haz the power, 2015-01-28 23:08:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-28 23:10:27]

Patchset 3 (id:??) landed as
https://crrev.com/ea2760c173e70ddcdcc64e0522a93d6a08785cae
Cr-Commit-Position: refs/heads/master@{#313604}