device/serial/test_serial_io_handler.h - Issue 873903002: Set serial connection parameters immediately on connect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/test_serial_io_handler.h

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment explaing the "set" notation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/serial/test_serial_io_handler.h

diff --git a/device/serial/test_serial_io_handler.h b/device/serial/test_serial_io_handler.h

index dfa27dbf09b523a332d4c37597aa45e6d755932c..52cb16a520f76f095ed61b8cb6352881e96eb9dc 100644

--- a/device/serial/test_serial_io_handler.h

+++ b/device/serial/test_serial_io_handler.h

@@ -21,12 +21,13 @@ class TestSerialIoHandler : public SerialIoHandler {

// SerialIoHandler overrides.

void Open(const std::string& port,

+ const serial::ConnectionOptions& options,

const OpenCompleteCallback& callback) override;

- bool ConfigurePort(const serial::ConnectionOptions& options) override;

void ReadImpl() override;

void CancelReadImpl() override;

void WriteImpl() override;

void CancelWriteImpl() override;

+ bool ConfigurePortImpl() override;

serial::DeviceControlSignalsPtr GetControlSignals() const override;

serial::ConnectionInfoPtr GetPortInfo() const override;

bool Flush() const override;

« no previous file with comments | « device/serial/serial_service_unittest.cc ('k') | device/serial/test_serial_io_handler.cc » ('j') | no next file with comments »