Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: device/serial/serial_service_unittest.cc

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment explaing the "set" notation. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | device/serial/test_serial_io_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "device/serial/serial.mojom.h" 8 #include "device/serial/serial.mojom.h"
9 #include "device/serial/serial_service_impl.h" 9 #include "device/serial/serial_service_impl.h"
10 #include "device/serial/test_serial_io_handler.h" 10 #include "device/serial/test_serial_io_handler.h"
(...skipping 10 matching lines...) Expand all
21 mojo::Array<serial::DeviceInfoPtr> devices(1); 21 mojo::Array<serial::DeviceInfoPtr> devices(1);
22 devices[0] = serial::DeviceInfo::New(); 22 devices[0] = serial::DeviceInfo::New();
23 devices[0]->path = "device"; 23 devices[0]->path = "device";
24 return devices.Pass(); 24 return devices.Pass();
25 } 25 }
26 }; 26 };
27 27
28 class FailToOpenIoHandler : public TestSerialIoHandler { 28 class FailToOpenIoHandler : public TestSerialIoHandler {
29 public: 29 public:
30 void Open(const std::string& port, 30 void Open(const std::string& port,
31 const serial::ConnectionOptions& options,
31 const OpenCompleteCallback& callback) override { 32 const OpenCompleteCallback& callback) override {
32 callback.Run(false); 33 callback.Run(false);
33 } 34 }
34 35
35 protected: 36 protected:
36 ~FailToOpenIoHandler() override {} 37 ~FailToOpenIoHandler() override {}
37 }; 38 };
38 39
39 } // namespace 40 } // namespace
40 41
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 TEST_F(SerialServiceTest, ConnectInvalidPath) { 133 TEST_F(SerialServiceTest, ConnectInvalidPath) {
133 RunConnectTest("invalid_path", false); 134 RunConnectTest("invalid_path", false);
134 } 135 }
135 136
136 TEST_F(SerialServiceTest, ConnectOpenFailed) { 137 TEST_F(SerialServiceTest, ConnectOpenFailed) {
137 io_handler_ = new FailToOpenIoHandler; 138 io_handler_ = new FailToOpenIoHandler;
138 RunConnectTest("device", false); 139 RunConnectTest("device", false);
139 } 140 }
140 141
141 } // namespace device 142 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | device/serial/test_serial_io_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698