Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873803002: Add webkitAudioPannerNode as an optional name (Closed)

Created:
5 years, 11 months ago by Alan Knight
Modified:
5 years, 11 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add webkitAudioPannerNode as an optional name BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43149

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/audiocontext_test.dart View 2 chunks +7 lines, -5 lines 2 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
dartbug.com/14354
5 years, 11 months ago (2015-01-23 19:33:38 UTC) #2
terry
LGTM https://codereview.chromium.org/873803002/diff/1/tests/html/audiocontext_test.dart File tests/html/audiocontext_test.dart (right): https://codereview.chromium.org/873803002/diff/1/tests/html/audiocontext_test.dart#newcode23 tests/html/audiocontext_test.dart:23: var context; This doesn't need to be broken ...
5 years, 11 months ago (2015-01-23 19:58:09 UTC) #3
Alan Knight
https://codereview.chromium.org/873803002/diff/1/tests/html/audiocontext_test.dart File tests/html/audiocontext_test.dart (right): https://codereview.chromium.org/873803002/diff/1/tests/html/audiocontext_test.dart#newcode23 tests/html/audiocontext_test.dart:23: var context; On 2015/01/23 19:58:09, terry wrote: > This ...
5 years, 11 months ago (2015-01-23 20:15:01 UTC) #4
Alan Knight
5 years, 11 months ago (2015-01-26 20:27:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698