Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: tests/html/audiocontext_test.dart

Issue 873803002: Add webkitAudioPannerNode as an optional name (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_audio/dart2js/web_audio_dart2js.dart ('k') | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/audiocontext_test.dart
diff --git a/tests/html/audiocontext_test.dart b/tests/html/audiocontext_test.dart
index 318332b69e962b6c60f74db7ad0c3fc564d43afd..68c2af9a9fdade2d3b71fbf0c6b56ea036c7a418 100644
--- a/tests/html/audiocontext_test.dart
+++ b/tests/html/audiocontext_test.dart
@@ -20,17 +20,20 @@ main() {
});
group('functional', () {
+ var context;
terry 2015/01/23 19:58:09 This doesn't need to be broken out? Assumed this
Alan Knight 2015/01/23 20:15:01 When I made too many different tests you started g
+ if (AudioContext.supported) {
+ context = new AudioContext();
+ }
+
test('constructorTest', () {
if(AudioContext.supported) {
- var ctx = new AudioContext();
- expect(ctx, isNotNull);
- expect(ctx, isAudioContext);
+ expect(context, isNotNull);
+ expect(context, isAudioContext);
}
});
test('audioRenames', () {
if(AudioContext.supported) {
- AudioContext context = new AudioContext();
GainNode gainNode = context.createGain();
gainNode.connectNode(context.destination);
expect(gainNode is GainNode, isTrue);
@@ -67,7 +70,6 @@ main() {
test('oscillatorTypes', () {
if(AudioContext.supported) {
- AudioContext context = new AudioContext();
OscillatorNode oscillator = context.createOscillator();
oscillator.connectNode(context.destination);
« no previous file with comments | « sdk/lib/web_audio/dart2js/web_audio_dart2js.dart ('k') | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698