Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873563002: [Ozone] Constrain the cursor when overscan insets are set (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
Reviewers:
sadrul, oshima, spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, tdresser+watch_chromium.org, sadrul, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Constrain the cursor when overscan insets are set Constrain the mouse cursor to the painted region of the screen when overscan insets are set. BUG=427619 TEST=Manual, see bug Committed: https://crrev.com/f52514eaab866573a7022cea2da3b93f1c18924d Cr-Commit-Position: refs/heads/master@{#313336}

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -100 lines) Patch
M ash/host/ash_window_tree_host_ozone.cc View 5 chunks +12 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_ozone.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 3 chunks +40 lines, -40 lines 0 comments Download
M ui/events/ozone/evdev/cursor_delegate_evdev.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 2 5 chunks +9 lines, -7 lines 0 comments Download
M ui/ozone/platform/caca/caca_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/caca/caca_window.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.h View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 2 10 chunks +29 lines, -22 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 1 2 5 chunks +15 lines, -2 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/test/test_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/test/test_window.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/platform_window/platform_window.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/platform_window/win/win_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/win/win_window.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/platform_window/x11/x11_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/x11/x11_window.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
pkotwicz
spang@ PTAL https://codereview.chromium.org/873563002/diff/20001/ui/ozone/platform/dri/dri_cursor.cc File ui/ozone/platform/dri/dri_cursor.cc (right): https://codereview.chromium.org/873563002/diff/20001/ui/ozone/platform/dri/dri_cursor.cc#newcode106 ui/ozone/platform/dri/dri_cursor.cc:106: Yes, this is ugly... https://codereview.chromium.org/873563002/diff/20001/ui/platform_window/platform_window.h File ui/platform_window/platform_window.h ...
5 years, 11 months ago (2015-01-23 03:40:27 UTC) #3
spang
just some nits https://codereview.chromium.org/873563002/diff/20001/ui/ozone/platform/dri/dri_cursor.cc File ui/ozone/platform/dri/dri_cursor.cc (right): https://codereview.chromium.org/873563002/diff/20001/ui/ozone/platform/dri/dri_cursor.cc#newcode67 ui/ozone/platform/dri/dri_cursor.cc:67: DriWindow* dri_window = window_manager_->GetWindow(window); Instead of ...
5 years, 11 months ago (2015-01-23 18:18:40 UTC) #4
pkotwicz
spang@ can you please take another look? I have made the changes that you have ...
5 years, 11 months ago (2015-01-23 20:35:28 UTC) #7
spang
lgtm
5 years, 11 months ago (2015-01-23 21:25:51 UTC) #8
pkotwicz
Sadrul, can you please take a look at the changes in ui/ (with the exception ...
5 years, 11 months ago (2015-01-23 21:27:52 UTC) #10
sadrul
LGTM Can there be some tests for the dri_window implementation of the new API? https://codereview.chromium.org/873563002/diff/80001/ui/ozone/platform/dri/dri_window.cc ...
5 years, 11 months ago (2015-01-26 18:13:29 UTC) #11
pkotwicz
I have filed crbug.com/452108 for adding tests to DriCursor. Will get to it on Tuesday ...
5 years, 11 months ago (2015-01-26 18:47:34 UTC) #12
pkotwicz
I have filed crbug.com/452108 for adding tests to DriCursor. Will get to it on Tuesday ...
5 years, 11 months ago (2015-01-26 18:47:36 UTC) #13
pkotwicz
+oshima for ash/host
5 years, 11 months ago (2015-01-26 19:21:23 UTC) #15
oshima
ash lgtm
5 years, 11 months ago (2015-01-26 19:28:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873563002/120001
5 years, 11 months ago (2015-01-27 17:56:08 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:120001)
5 years, 11 months ago (2015-01-27 20:08:48 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:10:55 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f52514eaab866573a7022cea2da3b93f1c18924d
Cr-Commit-Position: refs/heads/master@{#313336}

Powered by Google App Engine
This is Rietveld 408576698