[Ozone] Constrain the cursor when overscan insets are set

ui/ozone/platform/dri/dri_cursor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/dri/dri_cursor.h"
 
 #include "base/thread_task_runner_handle.h"
 #include "ui/base/cursor/ozone/bitmap_cursor_factory_ozone.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/point_conversions.h"
@@ skipping 45 matching lines @@
 #if DCHECK_IS_ON()
   if (!ui_task_runner_)
     ui_task_runner_ = base::ThreadTaskRunnerHandle::Get();
 #endif
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
 
   if (state_.window == gfx::kNullAcceleratedWidget) {
     // First window added & cursor is not placed. Place it.
     state_.window = window;
-    state_.bounds = bounds;
-    SetCursorLocationLocked(bounds.CenterPoint() - bounds.OffsetFromOrigin());
+    state_.display_bounds_in_screen = bounds;
+    DriWindow* dri_window = window_manager_->GetWindow(window);

[spang, 2015/01/23 18:18:40]

Instead of looking the window up, just change the signature.

OnWindowAdded(window, window_bounds, confined_bounds);

+    state_.confined_bounds = dri_window->GetCursorConfinedBounds();
+    SetCursorLocationLocked(state_.confined_bounds.CenterPoint());
   }
 }
 
 void DriCursor::OnWindowRemoved(gfx::AcceleratedWidget window) {
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
 
   if (state_.window == window) {
     // Try to find a new location for the cursor.
-    gfx::PointF screen_location =
-        state_.location + state_.bounds.OffsetFromOrigin();
     DriWindow* dest_window = window_manager_->GetPrimaryWindow();
 
     if (dest_window) {
       state_.window = dest_window->GetAcceleratedWidget();
-      state_.bounds = dest_window->GetBounds();
-      SetCursorLocationLocked(state_.bounds.CenterPoint() -
-                              state_.bounds.OffsetFromOrigin());
+      state_.display_bounds_in_screen = dest_window->GetBounds();
+      state_.confined_bounds = dest_window->GetCursorConfinedBounds();
+      SetCursorLocationLocked(state_.confined_bounds.CenterPoint());
       SendCursorShowLocked();
     } else {
       state_.window = gfx::kNullAcceleratedWidget;
-      state_.bounds = gfx::Rect();
+      state_.display_bounds_in_screen = gfx::Rect();
+      state_.confined_bounds = gfx::Rect();
       state_.location = gfx::Point();
     }
   }
 }
 
 void DriCursor::PrepareForBoundsChange(gfx::AcceleratedWidget window) {
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
 
   // Bounds changes can reparent the window to a different display, so
   // we hide prior to the change so that we avoid leaving a cursor
   // behind on the old display.
   // TODO(spang): The GPU-side code should handle this.
   if (state_.window == window)
     SendCursorHideLocked();
+

[pkotwicz, 2015/01/23 03:40:27]

Yes, this is ugly...

+  // The cursor will be shown and moved once the confined bounds for |window|
+  // are updated.
 }
 
-void DriCursor::CommitBoundsChange(gfx::AcceleratedWidget window,
-                                   const gfx::Rect& bounds) {
+void DriCursor::ConfineCursorToBounds(gfx::AcceleratedWidget window,
+                                      const gfx::Rect& bounds) {
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
   if (state_.window == window) {
-    state_.bounds = bounds;
+    state_.confined_bounds = bounds;
     SetCursorLocationLocked(state_.location);
     SendCursorShowLocked();
   }
 }
 
 void DriCursor::MoveCursorTo(gfx::AcceleratedWidget window,
                              const gfx::PointF& location) {
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
   gfx::AcceleratedWidget old_window = state_.window;
 
   if (window != old_window) {
     // When moving between displays, hide the cursor on the old display
     // prior to showing it on the new display.
     if (old_window != gfx::kNullAcceleratedWidget)
       SendCursorHideLocked();
 
     DriWindow* dri_window = window_manager_->GetWindow(window);
-    state_.bounds = dri_window->GetBounds();
+    state_.display_bounds_in_screen = dri_window->GetBounds();
+    state_.confined_bounds = dri_window->GetCursorConfinedBounds();
     state_.window = window;
   }
 
   SetCursorLocationLocked(location);
 
   if (window != old_window)
     SendCursorShowLocked();
   else
     SendCursorMoveLocked();
 }
 
 void DriCursor::MoveCursorTo(const gfx::PointF& screen_location) {
   base::AutoLock lock(state_.lock);
 
   // TODO(spang): Moving between windows doesn't work here, but
   // is not needed for current uses.
 
-  SetCursorLocationLocked(screen_location - state_.bounds.OffsetFromOrigin());
+  SetCursorLocationLocked(screen_location -
+                          state_.display_bounds_in_screen.OffsetFromOrigin());
 }
 
 void DriCursor::MoveCursor(const gfx::Vector2dF& delta) {
   base::AutoLock lock(state_.lock);
   if (state_.window == gfx::kNullAcceleratedWidget)
     return;
 
   gfx::Point location;
 #if defined(OS_CHROMEOS)
   gfx::Vector2dF transformed_delta = delta;
   ui::CursorController::GetInstance()->ApplyCursorConfigForWindow(
       state_.window, &transformed_delta);
   SetCursorLocationLocked(state_.location + transformed_delta);
 #else
   SetCursorLocationLocked(state_.location + delta);
 #endif
 
   SendCursorMoveLocked();
 }
 
 bool DriCursor::IsCursorVisible() {
   base::AutoLock lock(state_.lock);
   return state_.bitmap;
 }
 
 gfx::PointF DriCursor::GetLocation() {
   base::AutoLock lock(state_.lock);
-  return state_.location + state_.bounds.OffsetFromOrigin();
+  return state_.location + state_.display_bounds_in_screen.OffsetFromOrigin();
 }
 
-gfx::Rect DriCursor::GetCursorDisplayBounds() {
+gfx::Rect DriCursor::GetCursorConfinedBounds() {
   base::AutoLock lock(state_.lock);
-  return state_.bounds;
+  return state_.confined_bounds +
+         state_.display_bounds_in_screen.OffsetFromOrigin();
 }
 
 void DriCursor::OnChannelEstablished(
     int host_id,
     scoped_refptr<base::SingleThreadTaskRunner> send_runner,
     const base::Callback<void(IPC::Message*)>& send_callback) {
 #if DCHECK_IS_ON()
   if (!ui_task_runner_)
     ui_task_runner_ = base::ThreadTaskRunnerHandle::Get();
 #endif
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
   state_.send_runner = send_runner;
   state_.send_callback = send_callback;
   // Initial set for this GPU process will happen after the window
-  // initializes, in CommitBoundsChange.
+  // initializes, in ConfineCursorToBounds().
 }
 
 void DriCursor::OnChannelDestroyed(int host_id) {
   DCHECK(ui_task_runner_->BelongsToCurrentThread());
   base::AutoLock lock(state_.lock);
   state_.send_runner = NULL;
   state_.send_callback.Reset();
 }
 
 bool DriCursor::OnMessageReceived(const IPC::Message& message) {
   return false;
 }
 
 void DriCursor::SetCursorLocationLocked(const gfx::PointF& location) {
   state_.lock.AssertAcquired();
 
-  const gfx::Size& size = state_.bounds.size();
   gfx::PointF clamped_location = location;
-  clamped_location.SetToMax(gfx::PointF(0, 0));
+  clamped_location.SetToMax(
+      gfx::PointF(state_.confined_bounds.x(), state_.confined_bounds.y()));

[spang, 2015/01/23 18:18:40]

Point(rect.x(), rect.y()) is just rect.origin()

   // Right and bottom edges are exclusive.
-  clamped_location.SetToMin(gfx::PointF(size.width() - 1, size.height() - 1));
+  clamped_location.SetToMin(gfx::PointF(state_.confined_bounds.right() - 1,
+                                        state_.confined_bounds.bottom() - 1));
 
   state_.location = clamped_location;
 }
 
 gfx::Point DriCursor::GetBitmapLocationLocked() {
   return gfx::ToFlooredPoint(state_.location) -
          state_.bitmap->hotspot().OffsetFromOrigin();
 }
 
 bool DriCursor::IsConnectedLocked() {
@@ skipping 25 matching lines @@
 }
 
 void DriCursor::SendLocked(IPC::Message* message) {
   state_.lock.AssertAcquired();
 
   if (IsConnectedLocked() &&
       state_.send_runner->PostTask(FROM_HERE,
                                    base::Bind(state_.send_callback, message)))
     return;
 
-  // Drop disconnected updates. DriWindow will call CommitBoundsChange()
+  // Drop disconnected updates. DriWindow will call ConfineCursorToBounds()
   // when we connect to initialize the cursor location.
   delete message;
 }
 
 DriCursor::CursorState::CursorState() : window(gfx::kNullAcceleratedWidget) {
 }
 
 DriCursor::CursorState::~CursorState() {
 }
 
 }  // namespace ui