Changed the call to attach the debugger to V8 to run in the renderer thread. ...

Changed the call to attach the debugger to V8 to run in the renderer thread. With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread.

This change does not require the changes in V8 r648, but will not have any effect without.

Added a few comments.

BUG=3723
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4875

[Erik does not do reviews, 2008-11-05 17:00:13]

LGTM - thanks for tracking this down.

Just some typos and other comment nits.

http://codereview.chromium.org/8735/diff/1/2
File chrome/renderer/debug_message_handler.cc (right):

http://codereview.chromium.org/8735/diff/1/2#newcode43
Line 43: // Set the debug break flag in the V8 enging.
typo -> engine

http://codereview.chromium.org/8735/diff/1/2#newcode46
Line 46: // If a forced break has been requested make sure that it will occour
by
typo: "occur"

http://codereview.chromium.org/8735/diff/1/2#newcode61
Line 61: // most run in the V8 thread.
most -> must

http://codereview.chromium.org/8735/diff/1/3
File chrome/renderer/debug_message_handler.h (right):

http://codereview.chromium.org/8735/diff/1/3#newcode24
Line 24: // Evaluate javascript URL in the renderer
add a period while you're at it

http://codereview.chromium.org/8735/diff/1/3#newcode27
Line 27: // Attach in the renderer
same here.  Also, rephrase to include the thread issue.