Changed the call to attach the debugger to V8 to run in the renderer thread. ...

chrome/renderer/debug_message_handler.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/debug_message_handler.h"
 #include "chrome/renderer/render_view.h"
 
 ////////////////////////////////////////
 // methods called from the RenderThread
 
 DebugMessageHandler::DebugMessageHandler(RenderView* view) :
     debugger_(NULL), view_(view), channel_(NULL) {
   view_loop_ = MessageLoop::current();
   view_routing_id_ = view_->routing_id();
 }
 
 DebugMessageHandler::~DebugMessageHandler() {
 }
 
 void DebugMessageHandler::EvaluateScriptUrl(const std::wstring& url) {
   DCHECK(MessageLoop::current() == view_loop_);
   // It's possible that this will get cleared out from under us.
   RenderView* view = view_;
   if (view) {
     view->EvaluateScriptUrl(L"", url);
   }
 }
 
+void DebugMessageHandler::Attach() {
+  DCHECK(MessageLoop::current() == view_loop_);
+  debugger_->Attach();
+}
+
+
 ///////////////////////////////////////////////
 // all methods below called from the IO thread
 
 void DebugMessageHandler::DebuggerOutput(const std::wstring& out) {
   channel_->Send(new ViewHostMsg_DebuggerOutput(view_routing_id_, out));
 }
 
 void DebugMessageHandler::OnBreak(bool force) {
+  // Set the debug break flag in the V8 enging.

[Erik does not do reviews, 2008/11/05 17:00:13]

typo -> engine

   debugger_->Break(force);
+
+  // If a forced break has been requested make sure that it will occour by

[Erik does not do reviews, 2008/11/05 17:00:13]

typo: "occur"

+  // running some JavaScript in the renderer.
   if (force && view_loop_) {
     view_loop_->PostTask(FROM_HERE, NewRunnableMethod(
         this, &DebugMessageHandler::EvaluateScriptUrl,
         std::wstring(L"javascript:void(0)")));
   }
 }
 
 void DebugMessageHandler::OnAttach() {
   if (!debugger_) {
     debugger_ = new Debugger(this);
   }
-  debugger_->Attach();
+
+  // Run the actual debugger attach in the renderer as it uses V8 methods which
+  // most run in the V8 thread.

[Erik does not do reviews, 2008/11/05 17:00:13]

most -> must

+  if (view_loop_) {
+    view_loop_->PostTask(FROM_HERE, NewRunnableMethod(
+        this, &DebugMessageHandler::Attach));
+  }
 }
 
 void DebugMessageHandler::OnCommand(const std::wstring& cmd) {
   if (!debugger_) {
     NOTREACHED();
     std::wstring msg =
         StringPrintf(L"before attach, ignored command (%S)", cmd.c_str());
     DebuggerOutput(msg);
   } else {
     debugger_->Command(cmd);
@@ skipping 45 matching lines @@
     // hang forever and never exit.  To avoid this, we look for close messages
     // and tell the debugger to shutdown.
     IPC_MESSAGE_HANDLER_GENERIC(ViewMsg_Close,
       if (debugger_) OnDetach();
       handled = false;)
     IPC_MESSAGE_UNHANDLED(handled = false);
   IPC_END_MESSAGE_MAP()
   return handled;
 }