chrome/renderer/debug_message_handler.h - Issue 8735: Changed the call to attach the debugger to V8 to run in the renderer thread. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/debug_message_handler.h

Issue 8735: Changed the call to attach the debugger to V8 to run in the renderer thread. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/debug_message_handler.h

===================================================================

--- chrome/renderer/debug_message_handler.h (revision 4124)

+++ chrome/renderer/debug_message_handler.h (working copy)

@@ -21,9 +21,12 @@

virtual ~DebugMessageHandler();

private:

- // evaluate javascript URL in the renderer

+ // Evaluate javascript URL in the renderer

Erik does not do reviews 2008/11/05 17:00:13 add a period while you're at it

void EvaluateScriptUrl(const std::wstring& url);

+ // Attach in the renderer

Erik does not do reviews 2008/11/05 17:00:13 same here. Also, rephrase to include the thread i

+ void Attach();

// Debugger::Delegate callback method to handle debugger output.

void DebuggerOutput(const std::wstring& out);

« no previous file with comments | « no previous file | chrome/renderer/debug_message_handler.cc » ('j') | chrome/renderer/debug_message_handler.cc » ('J')