Re-land second sandbox round of changes...

Re-land second sandbox round of changes
- broke integration tests

See http://codereview.chromium.org/757001

BUG=27218
TEST=included

No change in the original files.
The only changes are in the files:

sandbox/src/registry_dispatcher.cc
sandbox/src/registry_dispatcher.h
sandbox/src/filesystem_dispatcher.cc

Because now even in 32 bits the handles map to void pointers

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41523

[cpu_(ooo_6.6-7.5), 2010-03-13 02:00:45]

maybe I can get QLGTM ..

[rvargas (doing something else), 2010-03-13 02:05:29]

LGTM

[nsylvain, 2010-03-13 02:06:13]

You forgot the gcl add the files. But i went to your computer and svn
diff'ed them. LGTM.  gcl add before commit. thanks for not locking your
machine.


On Fri, Mar 12, 2010 at 6:00 PM, <cpu@chromium.org> wrote:

> Reviewers: rvargas, nsylvain,
>
> Message:
> maybe I can get QLGTM ..
>
> Description:
> Re-land second sandbox round of changes
> - broke integration tests
>
> See http://codereview.chromium.org/757001
>
> BUG=27218
> TEST=included
>
> No change in the original files.
> The only changes are in the files:
>
> sandbox/src/registry_dispatcher.cc
> sandbox/src/registry_dispatcher.h
> sandbox/src/filesystem_dispatcher.cc
>
> Because now even in 32 bits the handles map to void pointers
>
> Please review this at http://codereview.chromium.org/873006
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     sandbox/sandbox.gyp
>  M     sandbox/src/crosscall_client.h
>  M     sandbox/src/crosscall_server.h
>  M     sandbox/src/crosscall_server.cc
>  M     sandbox/src/filesystem_dispatcher.cc
>  M     sandbox/src/interceptors_64.cc
>  M     sandbox/src/ipc_unittest.cc
>  M     sandbox/src/policy_broker.cc
>  M     sandbox/src/policy_target_test.cc
>  M     sandbox/src/process_thread_dispatcher.h
>  M     sandbox/src/process_thread_dispatcher.cc
>  M     sandbox/src/process_thread_policy.h
>  M     sandbox/src/process_thread_policy.cc
>  M     sandbox/src/registry_dispatcher.h
>  M     sandbox/src/registry_dispatcher.cc
>  M     sandbox/src/sandbox_policy_base.cc
>  M     sandbox/src/sharedmem_ipc_server.h
>  M     sandbox/src/sharedmem_ipc_server.cc
>  M     sandbox/tests/validation_tests/commands.cc
>  M     sandbox/tests/validation_tests/suite.cc
>
>
>

[nsylvain, 2010-03-13 02:06:42]

On Fri, Mar 12, 2010 at 6:05 PM, Nicolas Sylvain <nsylvain@google.com>wrote:

> You forgot the gcl add the files. But i went to your computer and svn
> diff'ed them. LGTM.  gcl add before commit. thanks for not locking your
> machine.

Ah. nevermind. was looking at the old one :(

>
>
> On Fri, Mar 12, 2010 at 6:00 PM, <cpu@chromium.org> wrote:
>
>> Reviewers: rvargas, nsylvain,
>>
>> Message:
>> maybe I can get QLGTM ..
>>
>> Description:
>> Re-land second sandbox round of changes
>> - broke integration tests
>>
>> See http://codereview.chromium.org/757001
>>
>> BUG=27218
>> TEST=included
>>
>> No change in the original files.
>> The only changes are in the files:
>>
>> sandbox/src/registry_dispatcher.cc
>> sandbox/src/registry_dispatcher.h
>> sandbox/src/filesystem_dispatcher.cc
>>
>> Because now even in 32 bits the handles map to void pointers
>>
>> Please review this at http://codereview.chromium.org/873006
>>
>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>
>> Affected files:
>>  M     sandbox/sandbox.gyp
>>  M     sandbox/src/crosscall_client.h
>>  M     sandbox/src/crosscall_server.h
>>  M     sandbox/src/crosscall_server.cc
>>  M     sandbox/src/filesystem_dispatcher.cc
>>  M     sandbox/src/interceptors_64.cc
>>  M     sandbox/src/ipc_unittest.cc
>>  M     sandbox/src/policy_broker.cc
>>  M     sandbox/src/policy_target_test.cc
>>  M     sandbox/src/process_thread_dispatcher.h
>>  M     sandbox/src/process_thread_dispatcher.cc
>>  M     sandbox/src/process_thread_policy.h
>>  M     sandbox/src/process_thread_policy.cc
>>  M     sandbox/src/registry_dispatcher.h
>>  M     sandbox/src/registry_dispatcher.cc
>>  M     sandbox/src/sandbox_policy_base.cc
>>  M     sandbox/src/sharedmem_ipc_server.h
>>  M     sandbox/src/sharedmem_ipc_server.cc
>>  M     sandbox/tests/validation_tests/commands.cc
>>  M     sandbox/tests/validation_tests/suite.cc
>>
>>
>>
>