Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: sandbox/src/policy_target_test.cc

Issue 873006: Re-land second sandbox round of changes... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/src/policy_broker.cc ('k') | sandbox/src/process_thread_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/src/policy_target_test.cc
===================================================================
--- sandbox/src/policy_target_test.cc (revision 41493)
+++ sandbox/src/policy_target_test.cc (working copy)
@@ -150,10 +150,10 @@
STARTUPINFO startup_info = {0};
startup_info.cb = sizeof(startup_info);
PROCESS_INFORMATION process_info;
- ::CreateProcess(L"foo.exe", L"foo.exe", NULL, NULL, FALSE, 0, NULL, NULL,
- &startup_info, &process_info);
-
- return SBOX_TEST_SUCCEEDED;
+ if (!::CreateProcessW(L"foo.exe", L"foo.exe", NULL, NULL, FALSE, 0,
+ NULL, NULL, &startup_info, &process_info))
+ return SBOX_TEST_SUCCEEDED;
+ return SBOX_TEST_FAILED;
}
TEST(PolicyTargetTest, SetInformationThread) {
@@ -194,8 +194,6 @@
EXPECT_EQ(ERROR_NO_TOKEN, runner.RunTest(L"PolicyTargetTest_token3"));
}
-#if !defined(_WIN64)
-// Bug 27218: We don't have dispatch for some x64 syscalls.
TEST(PolicyTargetTest, OpenThread) {
TestRunner runner;
EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"PolicyTargetTest_thread")) <<
@@ -211,6 +209,8 @@
"Opens a process";
}
+#if !defined(_WIN64)
+
// Launches the app in the sandbox and ask it to wait in an
// infinite loop. Waits for 2 seconds and then check if the
// desktop associated with the app thread is not the same as the
« no previous file with comments | « sandbox/src/policy_broker.cc ('k') | sandbox/src/process_thread_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698