Re-land second sandbox round of changes...

sandbox/src/process_thread_policy.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/src/process_thread_policy.h"
 
 #include <string>
 
 #include "base/scoped_ptr.h"
 #include "sandbox/src/ipc_tags.h"
 #include "sandbox/src/nt_internals.h"
@@ skipping 84 matching lines @@
   }
   if (!policy->AddRule(IPC_CREATEPROCESSW_TAG, process.get())) {
     return false;
   }
   return true;
 }
 
 NTSTATUS ProcessPolicy::OpenThreadAction(const ClientInfo& client_info,
                                          uint32 desired_access,
                                          uint32 thread_id,
-                                         HANDLE *handle) {
+                                         HANDLE* handle) {
   *handle = NULL;
 
   NtOpenThreadFunction NtOpenThread = NULL;
   ResolveNTFunctionPtr("NtOpenThread", &NtOpenThread);
 
   OBJECT_ATTRIBUTES attributes = {0};
   attributes.Length = sizeof(attributes);
   CLIENT_ID client_id = {0};
   client_id.UniqueProcess = reinterpret_cast<PVOID>(
                                 static_cast<ULONG_PTR>(client_info.process_id));
@@ skipping 11 matching lines @@
       return STATUS_ACCESS_DENIED;
     }
   }
 
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessAction(const ClientInfo& client_info,
                                           uint32 desired_access,
                                           uint32 process_id,
-                                          HANDLE *handle) {
+                                          HANDLE* handle) {
   *handle = NULL;
 
   NtOpenProcessFunction NtOpenProcess = NULL;
   ResolveNTFunctionPtr("NtOpenProcess", &NtOpenProcess);
 
   if (client_info.process_id != process_id)
     return STATUS_ACCESS_DENIED;
 
   OBJECT_ATTRIBUTES attributes = {0};
   attributes.Length = sizeof(attributes);
   CLIENT_ID client_id = {0};
   client_id.UniqueProcess = reinterpret_cast<PVOID>(
                                 static_cast<ULONG_PTR>(client_info.process_id));
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcess(&local_handle, desired_access, &attributes,
                                   &client_id);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
       ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
 
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessTokenAction(const ClientInfo& client_info,
-                                               uint32 process_requested,
+                                               HANDLE process,
                                                uint32 desired_access,
-                                               HANDLE *handle) {
+                                               HANDLE* handle) {
   *handle = NULL;
-
   NtOpenProcessTokenFunction NtOpenProcessToken = NULL;
   ResolveNTFunctionPtr("NtOpenProcessToken", &NtOpenProcessToken);
 
-  HANDLE process = reinterpret_cast<HANDLE>(
-                      static_cast<ULONG_PTR>(process_requested));
   if (CURRENT_PROCESS != process)
     return STATUS_ACCESS_DENIED;
 
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcessToken(client_info.process, desired_access,
                                        &local_handle);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
       ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
-
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessTokenExAction(const ClientInfo& client_info,
-                                                 uint32 process_requested,
+                                                 HANDLE process,
                                                  uint32 desired_access,
                                                  uint32 attributes,
-                                                 HANDLE *handle) {
+                                                 HANDLE* handle) {
   *handle = NULL;
   NtOpenProcessTokenExFunction NtOpenProcessTokenEx = NULL;
   ResolveNTFunctionPtr("NtOpenProcessTokenEx", &NtOpenProcessTokenEx);
 
-  HANDLE process = reinterpret_cast<HANDLE>(
-                      static_cast<ULONG_PTR>(process_requested));
   if (CURRENT_PROCESS != process)
     return STATUS_ACCESS_DENIED;
 
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcessTokenEx(client_info.process, desired_access,
                                          attributes, &local_handle);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
       ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
-
   return status;
 }
 
 DWORD ProcessPolicy::CreateProcessWAction(EvalResult eval_result,
                                           const ClientInfo& client_info,
                                           const std::wstring &app_name,
                                           const std::wstring &command_line,
                                           PROCESS_INFORMATION* process_info) {
   // The only action supported is ASK_BROKER which means create the process.
   if (GIVE_ALLACCESS != eval_result && GIVE_READONLY != eval_result) {
     return ERROR_ACCESS_DENIED;
   }
 
   STARTUPINFO startup_info = {0};
   startup_info.cb = sizeof(startup_info);
   scoped_ptr_malloc<wchar_t> cmd_line(_wcsdup(command_line.c_str()));
 
   BOOL should_give_full_access = (GIVE_ALLACCESS == eval_result);
   if (!CreateProcessExWHelper(client_info.process, should_give_full_access,
                               app_name.c_str(), cmd_line.get(), NULL, NULL,
                               FALSE, 0, NULL, NULL, &startup_info,
                               process_info)) {
     return ERROR_ACCESS_DENIED;
   }
   return ERROR_SUCCESS;
 }
 
 }  // namespace sandbox