Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872893004: Credential type enum from cpp to Java. (Closed)

Created:
5 years, 10 months ago by melandory
Modified:
5 years, 9 months ago
Reviewers:
Mike West, sky, newt (away)
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yolo_account_chooser_infobar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Credential type enum from cpp to Java. BUG=454815

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java View 1 3 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/password_manager/account_chooser_infobar_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +15 lines, -1 line 0 comments Download
M components/password_manager/content/common/credential_manager_types.h View 1 1 chunk +4 lines, -2 lines 1 comment Download
M components/password_manager/core/common/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
melandory
Hi all, review this CL please newt@ chrome/android/BUILD.gn chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java mkwst@ chrome/browser/password_manager/account_chooser_infobar_delegate_android.h chrome/browser/ui/passwords/manage_passwords_bubble_model.h chrome/browser/ui/passwords/manage_passwords_ui_controller.h components/password_manager.gypi components/password_manager/content/common/credential_manager_types.h ...
5 years, 10 months ago (2015-02-16 08:44:20 UTC) #6
melandory
Hi all, review this CL please newt@ chrome/android/BUILD.gn chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java mkwst@ chrome/browser/password_manager/account_chooser_infobar_delegate_android.h chrome/browser/ui/passwords/manage_passwords_bubble_model.h chrome/browser/ui/passwords/manage_passwords_ui_controller.h components/password_manager.gypi components/password_manager/content/common/credential_manager_types.h ...
5 years, 10 months ago (2015-02-16 08:44:53 UTC) #8
Mike West
LGTM.
5 years, 10 months ago (2015-02-16 10:19:55 UTC) #9
newt (away)
chrome/android/* lgtm https://codereview.chromium.org/872893004/diff/120001/components/password_manager/content/common/credential_manager_types.h File components/password_manager/content/common/credential_manager_types.h (right): https://codereview.chromium.org/872893004/diff/120001/components/password_manager/content/common/credential_manager_types.h#newcode30 components/password_manager/content/common/credential_manager_types.h:30: // GENERATED_JAVA_CLASS_NAME_OVERRIDE: CredentialType I believe you can ...
5 years, 10 months ago (2015-02-17 18:39:24 UTC) #10
sky
5 years, 10 months ago (2015-02-18 23:15:27 UTC) #11 
chrome.gyp LGTM

Powered by Google App Engine
This is Rietveld 408576698