components/password_manager/content/common/credential_manager_types.h - Issue 872893004: Credential type enum from cpp to Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_types.h

Issue 872893004: Credential type enum from cpp to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@yolo_account_chooser_infobar

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/content/common/credential_manager_types.h

diff --git a/components/password_manager/content/common/credential_manager_types.h b/components/password_manager/content/common/credential_manager_types.h

index 324288bff4367df1188061798c0def8926c14a2f..b98816d18af83a86fe1ee857bf24c0903657a721 100644

--- a/components/password_manager/content/common/credential_manager_types.h

+++ b/components/password_manager/content/common/credential_manager_types.h

@@ -26,8 +26,10 @@ namespace password_manager {

// something reasonably sane.

const size_t kMaxFederations = 50u;

-// TODO(melandory): Remove unsigned int.

-enum class CredentialType : unsigned int {

+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.password_manager

+// GENERATED_JAVA_CLASS_NAME_OVERRIDE: CredentialType

newt (away) 2015/02/17 18:39:24 I believe you can omit this line and the next one,

+// GENERATED_JAVA_PREFIX_TO_STRIP: CREDENTIAL_TYPE_

+enum class CredentialType {

CREDENTIAL_TYPE_EMPTY = 0,

CREDENTIAL_TYPE_LOCAL,

CREDENTIAL_TYPE_FEDERATED,

« no previous file with comments | « components/password_manager.gypi ('k') | components/password_manager/core/common/BUILD.gn » ('j') | no next file with comments »