Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3393)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java

Issue 872893004: Credential type enum from cpp to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@yolo_account_chooser_infobar
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
index 6f55e8ecffbdd1adabc8df40a1889611a52db617..57f1df20cdf731b84e5fdfca5d09c7758c519759 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
@@ -19,6 +19,7 @@ import android.widget.TextView;
import org.chromium.base.CalledByNative;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ResourceId;
+import org.chromium.chrome.browser.password_manager.CredentialType;
import org.chromium.chrome.browser.preferences.PreferencesLauncher;
/**
@@ -27,21 +28,6 @@ import org.chromium.chrome.browser.preferences.PreferencesLauncher;
* Google Smart Lock.
*/
public class AccountChooserInfoBar extends InfoBar implements OnMenuItemClickListener {
- private enum CredentialType {
- EMPTY(0),
- LOCAL(1),
- FEDERATED(2);
-
- private final int mType;
- private CredentialType(int type) {
- mType = type;
- };
-
- public int getValue() {
- return mType;
- }
- }
-
private final String[] mUsernames;
/**
@@ -163,8 +149,7 @@ public class AccountChooserInfoBar extends InfoBar implements OnMenuItemClickLis
private void passCredentialsToNative(Integer credentialIndex) {
// TODO(melandory): Adding federated login support should change this
// code.
- nativeOnCredentialClicked(
- mNativeInfoBarPtr, credentialIndex, CredentialType.LOCAL.getValue());
+ nativeOnCredentialClicked(mNativeInfoBarPtr, credentialIndex, CredentialType.LOCAL);
}
/** Pops up menu with two items: Setting and Learn More when user clicks more button*/

Powered by Google App Engine
This is Rietveld 408576698