Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7344)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 0515ecd840fd7f5bc6a071cc32795f5bb1f5f1f1..dcacf42c6ec7bf157a98057ba6a5f259e2296195 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -176,8 +176,8 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(
// This must be done after calculating |interstitial_reason_| above.
uma_helper_.reset(new SecurityInterstitialUmaHelper(
- web_contents, request_url(),
- GetHistogramPrefix(), GetSamplingEventName()));
+ web_contents, request_url(), GetUmaHistogramPrefix(),
+ GetRapporMetricPrefix(), GetSamplingEventName()));
uma_helper_->RecordUserDecision(SecurityInterstitialUmaHelper::SHOW);
uma_helper_->RecordUserInteraction(
SecurityInterstitialUmaHelper::TOTAL_VISITS);
@@ -555,7 +555,7 @@ bool SafeBrowsingBlockingPage::IsMainPageLoadBlocked(
return unsafe_resources.size() == 1 && !unsafe_resources[0].is_subresource;
}
-std::string SafeBrowsingBlockingPage::GetHistogramPrefix() const {
+std::string SafeBrowsingBlockingPage::GetUmaHistogramPrefix() const {
switch (interstitial_reason_) {
case SB_REASON_MALWARE:
return "malware";
@@ -568,6 +568,19 @@ std::string SafeBrowsingBlockingPage::GetHistogramPrefix() const {
return std::string();
}
+std::string SafeBrowsingBlockingPage::GetRapporMetricPrefix() const {
+ switch (interstitial_reason_) {
+ case SB_REASON_MALWARE:
+ return "Malware";
+ case SB_REASON_HARMFUL:
+ return "Harmful";
+ case SB_REASON_PHISHING:
+ return "Phishing";
+ }
+ NOTREACHED();
+ return std::string();
+}
+
std::string SafeBrowsingBlockingPage::GetSamplingEventName() const {
switch (interstitial_reason_) {
case SB_REASON_MALWARE:

Powered by Google App Engine
This is Rietveld 408576698