chrome/browser/ssl/ssl_blocking_page.cc - Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/security_interstitial_uma_helper.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | components/rappor/rappor_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_blocking_page.cc

diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc

index 214c035317d472aeb545d1b119b16fe900a7a83a..0574d97395c6b345d8c418b084113912a7ace6e1 100644

--- a/chrome/browser/ssl/ssl_blocking_page.cc

+++ b/chrome/browser/ssl/ssl_blocking_page.cc

@@ -235,7 +235,8 @@ SSLBlockingPage::SSLBlockingPage(content::WebContents* web_contents,

// This must be done after calculating |interstitial_reason_| above.

uma_helper_.reset(new SecurityInterstitialUmaHelper(

- web_contents, request_url, GetHistogramPrefix(), GetSamplingEventName()));

+ web_contents, request_url, GetHistogramPrefix(), "" /* rappor prefix */,

+ GetSamplingEventName()));

uma_helper_->RecordUserDecision(SecurityInterstitialUmaHelper::SHOW);

uma_helper_->RecordUserInteraction(

SecurityInterstitialUmaHelper::TOTAL_VISITS);