chrome/browser/safe_browsing/safe_browsing_blocking_page.h - Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/security_interstitial_uma_helper.cc ('K') | « chrome/browser/interstitials/security_interstitial_uma_helper.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

index 27ee2e6be716e7f090dc59f49c8ae0c7bf225f9a..2d880fd1f7b4483f2bd9dba3eb2e30cde30130d2 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

@@ -191,7 +191,8 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {

void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);

void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);

- std::string GetHistogramPrefix() const;

+ std::string GetUmaHistogramPrefix() const;

+ std::string GetRapporMetricPrefix() const;

std::string GetSamplingEventName() const;

scoped_ptr<SecurityInterstitialUmaHelper> uma_helper_;