Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872713004: Add glTransformFeedbackVaryings to GPU command buffer. (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, piman, no sievers, Ken Russell (switch to Gerrit), bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@caritas
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add glTransformFeedbackVaryings to GPU command buffer. BUG=429053 TEST=gpu_unittests R=vmiura@chromium.org Committed: https://crrev.com/38923567f136fb3dda353b84700cd47ac0077fbd Cr-Commit-Position: refs/heads/master@{#313771}

Patch Set 1 #

Patch Set 2 : fix 1 #

Patch Set 3 : fix 2 #

Patch Set 4 : working #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Fix comments #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -184 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 5 6 17 chunks +68 lines, -43 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 3 4 5 6 1 chunk +94 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 2 3 4 5 6 3 chunks +50 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 2 3 4 5 6 1 chunk +115 lines, -114 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 2 chunks +17 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 4 5 6 1 chunk +58 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 3 4 5 6 4 chunks +65 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Zhenyao Mo
vmiura: please review. Others: FYI (feel free to review)
5 years, 11 months ago (2015-01-23 22:39:04 UTC) #1
Ken Russell (switch to Gerrit)
This is great! All your hard work to generalize the entry points taking arrays of ...
5 years, 11 months ago (2015-01-24 03:15:36 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/872713004/diff/80001/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/872713004/diff/80001/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode1177 gpu/command_buffer/service/gles2_cmd_decoder.cc:1177: // Wrapper for glShaderSource. On 2015/01/24 03:15:36, Ken Russell ...
5 years, 10 months ago (2015-01-26 23:24:53 UTC) #4
Ken Russell (switch to Gerrit)
I'm not an owner in this directory and haven't done an in-depth review, but it ...
5 years, 10 months ago (2015-01-26 23:31:57 UTC) #5
vmiura
Sorry for the delay, LGTM.
5 years, 10 months ago (2015-01-29 20:10:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872713004/120001
5 years, 10 months ago (2015-01-29 20:14:14 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-01-29 20:18:11 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:19:14 UTC) #10
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/38923567f136fb3dda353b84700cd47ac0077fbd
Cr-Commit-Position: refs/heads/master@{#313771}

Powered by Google App Engine
This is Rietveld 408576698