Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 872433002: Fix flake in threaded CSSOM smooth scroll layout tests (Closed)

Created:
5 years, 11 months ago by ajuma
Modified:
5 years, 11 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flake in threaded CSSOM smooth scroll layout tests This removes waits and assertions about intermediate frames. In threaded mode, there's no guarantee about the frequency of main-thread frames as the animation progresses on the compositor thread. It's in fact possible to have no main-thread frames until the animation finishes; this causes tests that wait for an intermediate frame to time out, and causes tests that assert that the end frame isn't reached to fail. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M LayoutTests/fast/scroll-behavior/resources/scroll-behavior-test.js View 1 chunk +8 lines, -6 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
5 years, 11 months ago (2015-01-22 20:58:37 UTC) #2
Ian Vollick
On 2015/01/22 20:58:37, ajuma wrote: lgtm.
5 years, 11 months ago (2015-01-23 17:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872433002/1
5 years, 11 months ago (2015-01-23 17:28:46 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 18:44:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188898

Powered by Google App Engine
This is Rietveld 408576698