Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js

Issue 872433002: Fix flake in threaded CSSOM smooth scroll layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/scroll-behavior/resources/scroll-behavior-test.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js
diff --git a/LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js b/LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js
index 09fa4c9060d75387cfc4ae686ab210e00f69ddf7..26bc88f291fecd3c783d4331edffc92d5e80d894 100644
--- a/LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js
+++ b/LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js
@@ -75,12 +75,6 @@ SmoothScrollInterruptionTest.prototype.waitForSmoothScrollStart = function() {
return;
}
- var scrollElement = this.scrollElement;
- var scrollEndPoint = this.scrollEndPoint;
- this.asyncTest.step(function() {
- assert_not_equals(scrollElement.scrollTop, scrollEndPoint);
- });
-
var testCase = this.testCases[this.currentTestCase];
testCase.interruptSmoothScroll(this);
window.requestAnimationFrame(testCase.verifyScrollInterrupted.bind(testCase, this, this.testCaseComplete.bind(this)));
@@ -147,7 +141,7 @@ function interruptWithSmoothScroll(smoothScrollTest) {
function verifyScrollInterruptedBySmoothScroll(smoothScrollTest, verificationComplete) {
var currentPosition = smoothScrollTest.scrollElement.scrollTop;
- if (currentPosition < this.scrollInterruptionPoint && currentPosition > smoothScrollTest.scrollNewEndpoint) {
+ if (currentPosition < this.scrollInterruptionPoint && currentPosition >= smoothScrollTest.scrollNewEndpoint) {
verificationComplete();
} else {
window.requestAnimationFrame(this.verifyScrollInterrupted.bind(this, smoothScrollTest, verificationComplete));
« no previous file with comments | « LayoutTests/fast/scroll-behavior/resources/scroll-behavior-test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698