Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/android/java/res/layout/preference_float_label_layout.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually commit AddressField.java Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/preference_float_label_layout.xml
diff --git a/chrome/android/java/res/layout/preference_float_label_layout.xml b/chrome/android/java/res/layout/preference_float_label_layout.xml
new file mode 100644
index 0000000000000000000000000000000000000000..1d15b88c05027a425cbb69ca95bb753b80eb8c79
--- /dev/null
+++ b/chrome/android/java/res/layout/preference_float_label_layout.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<org.chromium.chrome.browser.widget.FloatLabelLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:app="http://schemas.android.com/apk/res-auto"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:id="@+id/float_label_layout" >
+ <EditText
+ android:id="@+id/address_edit_text"
Evan Stade 2015/01/28 03:07:47 this file seems generic but this id is "address_ed
Theresa 2015/01/28 03:33:47 The file name is poor, sorry. I'll change it. Thi
+ android:singleLine="true"
Evan Stade 2015/01/28 03:07:47 street address must be multiline
Theresa 2015/01/28 03:33:47 The mocks call for a single street address line, a
Evan Stade 2015/01/29 01:07:22 This is incorrect. Multiline street addresses are
Theresa 2015/01/29 05:22:13 Done.
+ android:layout_width="fill_parent"
+ android:layout_height="wrap_content"
+ android:inputType = "textPostalAddress|textCapWords" />
+</org.chromium.chrome.browser.widget.FloatLabelLayout>

Powered by Google App Engine
This is Rietveld 408576698