Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/homepage_preferences.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually commit AddressField.java Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/res/layout/autofill_profile_editor.xml ('K') | « chrome/android/java/res/layout/autofill_profile_label.xml ('k') | chrome/android/java/res/layout/preference_float_label_layout.xml » ('j') | chrome/android/java/res/layout/preference_float_label_layout.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/homepage_preferences.xml
diff --git a/chrome/android/java/res/layout/homepage_preferences.xml b/chrome/android/java/res/layout/homepage_preferences.xml
index 2a85ceb2306631cd37d8e2bd03ea619e0ae5319c..698b22311b25484c4419b4d2e56bef6f5892d7c3 100644
--- a/chrome/android/java/res/layout/homepage_preferences.xml
+++ b/chrome/android/java/res/layout/homepage_preferences.xml
@@ -14,13 +14,13 @@
android:layout_height="wrap_content"
android:clickable="true"
android:focusableInTouchMode="true"
- android:orientation="vertical"
- android:paddingTop="6dp" >
+ android:orientation="vertical" >
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_margin="6dp"
+ android:layout_marginStart="@dimen/pref_homepage_layout_margin"
newt (away) 2015/01/28 20:20:18 Why is this margin applied only to the label and t
Theresa 2015/01/29 05:22:13 It shouldn't be. Done.
+ android:layout_marginEnd="@dimen/pref_homepage_layout_margin"
android:orientation="horizontal" >
<TextView
« chrome/android/java/res/layout/autofill_profile_editor.xml ('K') | « chrome/android/java/res/layout/autofill_profile_label.xml ('k') | chrome/android/java/res/layout/preference_float_label_layout.xml » ('j') | chrome/android/java/res/layout/preference_float_label_layout.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698