chrome/android/java/res/layout/preference_float_label_layout.xml - Issue 872023002: Use floating labels for preference forms

Side by Side Diff: chrome/android/java/res/layout/preference_float_label_layout.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually commit AddressField.java Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/homepage_preferences.xml ('K') | « chrome/android/java/res/layout/homepage_preferences.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.widget.FloatLabelLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:app="http://schemas.android.com/apk/res-auto"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:id="@+id/float_label_layout" >

	12 <EditText

	13 android:id="@+id/address_edit_text"
	Evan Stade 2015/01/28 03:07:47 this file seems generic but this id is "address_ed this file seems generic but this id is "address_edit_text"? Theresa 2015/01/28 03:33:47 The file name is poor, sorry. I'll change it. Thi Show quoted text On 2015/01/28 03:07:47, Evan Stade wrote: > this file seems generic but this id is "address_edit_text"? The file name is poor, sorry. I'll change it. This layout is only intended to be used specifically for address fields since the inputType for the EditText is set to textPostalAddress\|textCapWords.
	14 android:singleLine="true"
	Evan Stade 2015/01/28 03:07:47 street address must be multiline street address must be multiline Theresa 2015/01/28 03:33:47 The mocks call for a single street address line, a Show quoted text On 2015/01/28 03:07:47, Evan Stade wrote: > street address must be multiline The mocks call for a single street address line, and multiline street addresses are deprecated. They're marked as such in the libaddressinput's AddressField.java and the AddressField enum on the C++ side doesn't even include a placeholder for the deprecated address_line_1 and address_line_2 fields. I tested with multiline street addresses, and if there's a line break in the street_address, it's displayed as a space in the single line EditText box. Evan Stade 2015/01/29 01:07:22 This is incorrect. Multiline street addresses are Show quoted text On 2015/01/28 03:33:47, twellington wrote: > On 2015/01/28 03:07:47, Evan Stade wrote: > > street address must be multiline > > The mocks call for a single street address line, and multiline street addresses > are deprecated. They're marked as such in the libaddressinput's > AddressField.java and the AddressField enum on the C++ side doesn't even include > a placeholder for the deprecated address_line_1 and address_line_2 fields. I > tested with multiline street addresses, and if there's a line break in the > street_address, it's displayed as a space in the single line EditText box. This is incorrect. Multiline street addresses are not deprecated. address_line_1 and address_line_2 are old, single-line inputs, and are deprecated because they should be replaced by a single, multiline street address of arbitrarily many lines. They don't appear in the mocks because 1) street addresses with just one line should look like one line and expand as necessary, and/or 2) the designer didn't consider the multiline case. Theresa 2015/01/29 05:22:13 Done. Show quoted text On 2015/01/29 01:07:22, Evan Stade wrote: > On 2015/01/28 03:33:47, twellington wrote: > > On 2015/01/28 03:07:47, Evan Stade wrote: > > > street address must be multiline > > > > The mocks call for a single street address line, and multiline street > addresses > > are deprecated. They're marked as such in the libaddressinput's > > AddressField.java and the AddressField enum on the C++ side doesn't even > include > > a placeholder for the deprecated address_line_1 and address_line_2 fields. I > > tested with multiline street addresses, and if there's a line break in the > > street_address, it's displayed as a space in the single line EditText box. > > This is incorrect. Multiline street addresses are not deprecated. address_line_1 > and address_line_2 are old, single-line inputs, and are deprecated because they > should be replaced by a single, multiline street address of arbitrarily many > lines. > > They don't appear in the mocks because > 1) street addresses with just one line should look like one line and expand as > necessary, and/or > 2) the designer didn't consider the multiline case. Done.
	15 android:layout_width="fill_parent"

	16 android:layout_height="wrap_content"

	17 android:inputType = "textPostalAddress\|textCapWords" />

	18 </org.chromium.chrome.browser.widget.FloatLabelLayout>

OLD	NEW