Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/android/java/res/layout/homepage_preferences.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually commit AddressField.java Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
7 android:layout_width="match_parent" 7 android:layout_width="match_parent"
8 android:layout_height="match_parent" 8 android:layout_height="match_parent"
9 android:fillViewport="true" 9 android:fillViewport="true"
10 style="@style/PreferenceScreenLayout" > 10 style="@style/PreferenceScreenLayout" >
11 11
12 <LinearLayout 12 <LinearLayout
13 android:layout_width="match_parent" 13 android:layout_width="match_parent"
14 android:layout_height="wrap_content" 14 android:layout_height="wrap_content"
15 android:clickable="true" 15 android:clickable="true"
16 android:focusableInTouchMode="true" 16 android:focusableInTouchMode="true"
17 android:orientation="vertical" 17 android:orientation="vertical" >
18 android:paddingTop="6dp" >
19 18
20 <LinearLayout 19 <LinearLayout
21 android:layout_width="match_parent" 20 android:layout_width="match_parent"
22 android:layout_height="wrap_content" 21 android:layout_height="wrap_content"
23 android:layout_margin="6dp" 22 android:layout_marginStart="@dimen/pref_homepage_layout_margin"
newt (away) 2015/01/28 20:20:18 Why is this margin applied only to the label and t
Theresa 2015/01/29 05:22:13 It shouldn't be. Done.
23 android:layout_marginEnd="@dimen/pref_homepage_layout_margin"
24 android:orientation="horizontal" > 24 android:orientation="horizontal" >
25 25
26 <TextView 26 <TextView
27 android:id="@+id/homepage_switch_label" 27 android:id="@+id/homepage_switch_label"
28 android:layout_width="0dp" 28 android:layout_width="0dp"
29 android:layout_weight="1" 29 android:layout_weight="1"
30 android:layout_height="wrap_content" 30 android:layout_height="wrap_content"
31 android:singleLine="true" 31 android:singleLine="true"
32 android:textAppearance="@style/PreferenceTextAppearanceMedium" / > 32 android:textAppearance="@style/PreferenceTextAppearanceMedium" / >
33 33
(...skipping 22 matching lines...) Expand all
56 <CheckBox 56 <CheckBox
57 android:id="@+id/default_checkbox" 57 android:id="@+id/default_checkbox"
58 android:layout_width="match_parent" 58 android:layout_width="match_parent"
59 android:layout_height="wrap_content" 59 android:layout_height="wrap_content"
60 android:layout_marginTop="6dp" 60 android:layout_marginTop="6dp"
61 android:layout_marginBottom="6dp" 61 android:layout_marginBottom="6dp"
62 android:text="@string/homepage_default_title" /> 62 android:text="@string/homepage_default_title" />
63 </LinearLayout> 63 </LinearLayout>
64 64
65 </ScrollView> 65 </ScrollView>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698