Download commit-msg from gerrit-review.googlesource.com

Download commit-msg from gerrit-review.googlesource.com

Tell download tools/hooks/commit-msg mannually if it looks broken.

chrome-internal-reviews.googlesource.com requires
authentication to access tools/hooks/commit-msg, and
we'll get Google Sign-in page rather than expected shell script.

R=szager@chromium.org,maruel@chromium.org,ilevy@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=237454

[M-A Ruel, 2013-11-26 14:06:55]

https://codereview.chromium.org/87173002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1041
git_cl.py:1041: def checkHookScript(fname):
s/checkHookScript/hasSheBang/

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1044
git_cl.py:1044: s = f.read()
return f.read(2).startswith('#!'):

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1065
git_cl.py:1065: checkHookScript(dst)
if not hasSheBang(dst):
  DieWithError('Not a script ...')

[M-A Ruel, 2013-11-26 14:07:03]

lgtm with fixes above.

[ukai, 2013-11-26 14:17:19]

https://codereview.chromium.org/87173002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1041
git_cl.py:1041: def checkHookScript(fname):
On 2013/11/26 14:06:56, M-A Ruel wrote:
> s/checkHookScript/hasSheBang/

Done.

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1044
git_cl.py:1044: s = f.read()
On 2013/11/26 14:06:56, M-A Ruel wrote:
> return f.read(2).startswith('#!'):

Done.

https://codereview.chromium.org/87173002/diff/20001/git_cl.py#newcode1065
git_cl.py:1065: checkHookScript(dst)
On 2013/11/26 14:06:56, M-A Ruel wrote:
> if not hasSheBang(dst):
>   DieWithError('Not a script ...')

Done.

[szager1, 2013-11-26 20:29:38]

lgtm

[commit-bot: I haz the power, 2013-11-27 00:51:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/87173002/40001

[commit-bot: I haz the power, 2013-11-27 00:53:00]

Change committed as 237454