Download commit-msg from gerrit-review.googlesource.com

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 1020 matching lines @@
             keyvals['ORIGIN_URL_CONFIG']])
 
 
 def urlretrieve(source, destination):
   """urllib is broken for SSL connections via a proxy therefore we
   can't use urllib.urlretrieve()."""
   with open(destination, 'w') as f:
     f.write(urllib2.urlopen(source).read())
 
 
+def checkHookScript(fname):

[M-A Ruel, 2013/11/26 14:06:56]

s/checkHookScript/hasSheBang/

[ukai, 2013/11/26 14:17:20]

Done.

+  """Checks fname is a script."""
+  with open(fname) as f:
+    s = f.read()

[M-A Ruel, 2013/11/26 14:06:56]

return f.read(2).startswith('#!'):

[ukai, 2013/11/26 14:17:20]

Done.

+    if not s.startswith('#!'):
+      raise Exception('unexpected script')
+
+
 def DownloadHooks(force):
   """downloads hooks
 
   Args:
     force: True to update hooks. False to install hooks if not present.
   """
   if not settings.GetIsGerrit():
     return
-  server_url = settings.GetDefaultServerUrl()
-  src = '%s/tools/hooks/commit-msg' % server_url
+  src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
   dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
   if not os.access(dst, os.X_OK):
     if os.path.exists(dst):
       if not force:
         return
-      os.remove(dst)
     try:
       urlretrieve(src, dst)
+      checkHookScript(dst)

[M-A Ruel, 2013/11/26 14:06:56]

if not hasSheBang(dst):
  DieWithError('Not a script ...')

[ukai, 2013/11/26 14:17:20]

Done.

       os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
     except Exception:
       if os.path.exists(dst):
         os.remove(dst)
-      DieWithError('\nFailed to download hooks from %s' % src)
+      DieWithError('\nFailed to download hooks.\n'
+                   'You need to download from\n%s\n'
+                   'into .git/hooks/commit-msg and '
+                   'chmod +x .git/hooks/commit-msg' % src)
 
 
 @subcommand.usage('[repo root containing codereview.settings]')
 def CMDconfig(parser, args):
   """Edits configuration for this tree."""
 
   _, args = parser.parse_args(args)
   if len(args) == 0:
     GetCodereviewSettingsInteractively()
     DownloadHooks(True)
@@ skipping 1247 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))