Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: tests/git_cl_test.py

Issue 87173002: Download commit-msg from gerrit-review.googlesource.com (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: change checkHookScript to hasSheBang, etc Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 23c0c647bc56caeb3aba93bf57ff09559d5e356b..dce632ea9f526310ec495e3af690f7181320fb82 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -649,6 +649,7 @@ class TestGitCl(TestCase):
return True
self.mock(git_cl.os.path, 'exists', Exists)
self.mock(git_cl, 'urlretrieve', self._mocked_call)
+ self.mock(git_cl, 'hasSheBang', self._mocked_call)
self.calls = [
((['git', 'config', 'rietveld.server',
'gerrit.chromium.org'],), ''),
@@ -665,12 +666,11 @@ class TestGitCl(TestCase):
# DownloadHooks(False)
((['git', 'config', 'gerrit.host'],),
'gerrit.chromium.org'),
- ((['git', 'config', 'rietveld.server'],),
- 'gerrit.chromium.org'),
((['git', 'rev-parse', '--show-cdup'],), ''),
((commit_msg_path, os.X_OK,), False),
- (('https://gerrit.chromium.org/tools/hooks/commit-msg',
+ (('https://gerrit-review.googlesource.com/tools/hooks/commit-msg',
commit_msg_path,), ''),
+ ((commit_msg_path,), True),
((commit_msg_path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR,), ''),
# GetCodereviewSettingsInteractively
((['git', 'config', 'rietveld.server'],),
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698