chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index 0e878190707b30146f89945f43110f66e0395b93..0a8ab5a530208c6b8e0d0f350b8947529140752d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -1015,7 +1015,7 @@ bool BookmarkBarView::CanDrop(const ui::OSExchangeData& data) {

// Only accept drops of 1 node, which is the case for all data dragged from

// bookmark bar and menus.

- return drop_info_->data.Read(data) && drop_info_->data.size() == 1;

+ return drop_info_->data.Read(data) && drop_info_->data.num_elements() == 1;

}

void BookmarkBarView::OnDragEntered(const DropTargetEvent& event) {