chrome/browser/ui/bookmarks/bookmark_utils.cc - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils.cc

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/bookmarks/bookmark_utils.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.cc b/chrome/browser/ui/bookmarks/bookmark_utils.cc

index f05929df54f05e7eeeefcf357a23a4512a10e4c5..d34b6bdb40c88d63683156de892c476e2baacb75 100644

--- a/chrome/browser/ui/bookmarks/bookmark_utils.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_utils.cc

@@ -414,7 +414,7 @@ int GetBookmarkDropOperation(Profile* profile,

int index) {

const base::FilePath& profile_path = profile->GetPath();

- if (data.IsFromProfilePath(profile_path) && data.size() > 1)

+ if (data.IsFromProfilePath(profile_path) && data.num_elements() > 1)

// Currently only accept one dragged node at a time.

return ui::DragDropTypes::DRAG_NONE;