chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

index 83585a507206b97823cac5a0e8bf6042b7219408..4220dff80753b8153f03791c59d1743fa46f6f95 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

@@ -182,7 +182,7 @@ bool BookmarkMenuDelegate::CanDrop(MenuItemView* menu,

// Only accept drops of 1 node, which is the case for all data dragged from

// bookmark bar and menus.

- if (!drop_data_.Read(data) || drop_data_.elements.size() != 1 ||

+ if (!drop_data_.Read(data) || drop_data_.num_elements() != 1 ||

!profile_->GetPrefs()->GetBoolean(

bookmarks::prefs::kEditBookmarksEnabled))

return false;