Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 870073003: Remove mouse events from Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3324 lines) Patch
M sky/engine/build/scripts/make_event_factory.py View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/core.gni View 10 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Document.h View 4 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 3 chunks +0 lines, -179 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Element.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.h View 3 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 5 chunks +0 lines, -33 lines 0 comments Download
D sky/engine/core/dom/SimulatedClickOptions.h View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/Event.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/events/EventAliases.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/EventDispatcher.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/EventDispatcher.cpp View 2 chunks +2 lines, -31 lines 0 comments Download
D sky/engine/core/events/MouseEvent.h View 1 chunk +0 lines, -140 lines 0 comments Download
D sky/engine/core/events/MouseEvent.cpp View 1 chunk +0 lines, -267 lines 0 comments Download
D sky/engine/core/events/MouseEvent.idl View 1 chunk +0 lines, -59 lines 0 comments Download
M sky/engine/core/events/NodeEventContext.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/events/UIEventWithKeyState.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/core/events/WheelEvent.h View 1 chunk +0 lines, -118 lines 0 comments Download
D sky/engine/core/events/WheelEvent.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
D sky/engine/core/events/WheelEvent.idl View 1 chunk +0 lines, -40 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 4 chunks +1 line, -14 lines 0 comments Download
D sky/engine/core/html/canvas/MouseEventHitRegion.h View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/engine/core/html/canvas/MouseEventHitRegion.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/loader/NavigationPolicy.h View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/loader/NavigationPolicy.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M sky/engine/core/page/AutoscrollController.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/EventHandler.h View 13 chunks +1 line, -56 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 21 chunks +3 lines, -1010 lines 0 comments Download
M sky/engine/core/page/EventWithHitTestResults.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 3 chunks +0 lines, -8 lines 2 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/PlatformMouseEvent.h View 1 chunk +0 lines, -110 lines 0 comments Download
D sky/engine/platform/PlatformWheelEvent.h View 1 chunk +0 lines, -98 lines 0 comments Download
M sky/engine/platform/exported/WebInputEvent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 3 chunks +0 lines, -65 lines 0 comments Download
M sky/engine/public/platform/WebInputEvent.h View 3 chunks +0 lines, -138 lines 0 comments Download
M sky/engine/public/web/WebNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 3 chunks +1 line, -52 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebInputEventConversion.h View 2 chunks +0 lines, -39 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 3 chunks +0 lines, -246 lines 0 comments Download
M sky/engine/web/WebNode.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 5 chunks +0 lines, -104 lines 0 comments Download
M sky/viewer/converters/input_event_types.cc View 3 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-23 20:13:44 UTC) #1
esprehn
rs lgtm
5 years, 11 months ago (2015-01-23 20:15:56 UTC) #2
abarth-chromium
Committed patchset #1 (id:1) manually as 7e3ecedfcf3ed39a8bff3cbb67b14884bfb84f7a (presubmit successful).
5 years, 11 months ago (2015-01-23 20:16:13 UTC) #3
ojan
https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp File sky/engine/core/rendering/RenderLayerScrollableArea.cpp (left): https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp#oldcode226 sky/engine/core/rendering/RenderLayerScrollableArea.cpp:226: frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseMoveEvent); Have we removed :hover? If not, then this ...
5 years, 11 months ago (2015-01-23 22:23:06 UTC) #4
abarth-chromium
https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp File sky/engine/core/rendering/RenderLayerScrollableArea.cpp (left): https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp#oldcode226 sky/engine/core/rendering/RenderLayerScrollableArea.cpp:226: frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseMoveEvent); On 2015/01/23 at 22:23:06, ojan wrote: > Have ...
5 years, 11 months ago (2015-01-23 22:39:29 UTC) #5
ojan
5 years, 11 months ago (2015-01-24 05:54:21 UTC) #6
Message was sent while issue was closed.
On 2015/01/23 at 22:39:29, abarth wrote:
>
https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/Re...
> File sky/engine/core/rendering/RenderLayerScrollableArea.cpp (left):
> 
>
https://codereview.chromium.org/870073003/diff/1/sky/engine/core/rendering/Re...
> sky/engine/core/rendering/RenderLayerScrollableArea.cpp:226:
frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseMoveEvent);
> On 2015/01/23 at 22:23:06, ojan wrote:
> > Have we removed :hover? If not, then this change makes is so that we don't
update hover state when you scroll (e.g. with the scroll wheel or keyboard).
> 
> IMHO, we should remove hover for now.  We don't have any hardware that
supports it yet.

Well, you can plug a mouse into an android device and that's an increasingly
common/important use case. But, removing it is fine with me. Adding it back in
when we're closer to shipping a product shouldn't be an enormous amount of work.
I thought we were leaving it in because we didn't want demos to be totally
broken if you plugged a mouse in. esprehn had told me that you had said to leave
it in for that reason. :) esprehn, removing hover OK with you?

Powered by Google App Engine
This is Rietveld 408576698