Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: sky/engine/core/html/HTMLAnchorElement.cpp

Issue 870073003: Remove mouse events from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/HTMLAnchorElement.cpp
diff --git a/sky/engine/core/html/HTMLAnchorElement.cpp b/sky/engine/core/html/HTMLAnchorElement.cpp
index f01cfd6c9dc88c9a9a73b7accdba09f2aeebb608..c34afc130ad687d92ea05762453d29da90a210e7 100644
--- a/sky/engine/core/html/HTMLAnchorElement.cpp
+++ b/sky/engine/core/html/HTMLAnchorElement.cpp
@@ -28,7 +28,6 @@
#include "sky/engine/core/dom/Attribute.h"
#include "sky/engine/core/editing/FrameSelection.h"
#include "sky/engine/core/events/KeyboardEvent.h"
-#include "sky/engine/core/events/MouseEvent.h"
#include "sky/engine/core/frame/FrameHost.h"
#include "sky/engine/core/frame/LocalFrame.h"
#include "sky/engine/core/frame/Settings.h"
@@ -39,7 +38,6 @@
#include "sky/engine/core/page/Chrome.h"
#include "sky/engine/core/page/ChromeClient.h"
#include "sky/engine/core/rendering/RenderImage.h"
-#include "sky/engine/platform/PlatformMouseEvent.h"
#include "sky/engine/platform/network/ResourceRequest.h"
#include "sky/engine/platform/weborigin/KnownPorts.h"
#include "sky/engine/platform/weborigin/SecurityPolicy.h"
@@ -51,14 +49,9 @@
namespace blink {
-static bool isEnterKeyKeydownEvent(Event* event)
-{
- return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter";
-}
-
static bool isLinkClick(Event* event)
{
- return event->type() == EventTypeNames::click && (!event->isMouseEvent() || toMouseEvent(event)->button() != RightButton);
+ return event->type() == EventTypeNames::click;
}
PassRefPtr<HTMLAnchorElement> HTMLAnchorElement::create(Document& document)
@@ -84,12 +77,6 @@ bool HTMLAnchorElement::supportsFocus() const
void HTMLAnchorElement::defaultEventHandler(Event* event)
{
- if (focused() && isEnterKeyKeydownEvent(event) && isLiveLink()) {
- event->setDefaultHandled();
- dispatchSimulatedClick(event);
- return;
- }
-
if (isLinkClick(event) && isLiveLink()) {
handleClick(event);
return;

Powered by Google App Engine
This is Rietveld 408576698