Committed patchset #2 (id:40001) manually as 8ad2a87e9d2ca440383f54a358ef294841242dca (presubmit successful).
5 years, 11 months ago
(2015-01-23 11:34:16 UTC)
#9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
8ad2a87e9d2ca440383f54a358ef294841242dca (presubmit successful).
Johann
Ugh, is there any way to get access to the bot, or a vista machine? ...
5 years, 11 months ago
(2015-01-23 16:16:13 UTC)
#10
Message was sent while issue was closed.
Ugh, is there any way to get access to the bot, or a vista machine? The tests
just time out silently. No idea what's up.
Johann
lgtm, btw
5 years, 11 months ago
(2015-01-23 16:20:40 UTC)
#11
Message was sent while issue was closed.
lgtm, btw
binjin
On 2015/01/23 16:16:13, Johann wrote: > Ugh, is there any way to get access to ...
5 years, 11 months ago
(2015-01-23 16:53:49 UTC)
#12
Message was sent while issue was closed.
On 2015/01/23 16:16:13, Johann wrote:
> Ugh, is there any way to get access to the bot, or a vista machine? The tests
> just time out silently. No idea what's up.
Just as Michael Achenbach's comment at https://codereview.chromium.org/845453005
, there are another avx change yesterday which breaks the windows xp/vista bots
constantly. Maybe the root causes are indeed similar?
Johann
On 2015/01/23 16:53:49, binjin wrote: > On 2015/01/23 16:16:13, Johann wrote: > > Ugh, is ...
5 years, 11 months ago
(2015-01-23 18:14:32 UTC)
#13
Message was sent while issue was closed.
On 2015/01/23 16:53:49, binjin wrote:
> On 2015/01/23 16:16:13, Johann wrote:
> > Ugh, is there any way to get access to the bot, or a vista machine? The
tests
> > just time out silently. No idea what's up.
>
> Just as Michael Achenbach's comment at
https://codereview.chromium.org/845453005
> , there are another avx change yesterday which breaks the windows xp/vista
bots
> constantly. Maybe the root causes are indeed similar?
Unfortunately the fix there appears related to whether they use AVX on the
target. Since the build appears to be passing, the next possibility is that the
AVX instructions that are generated are being run when the should not. I would
expect to see "invalid instruction" crashes in the log, not timeouts. An
experiment would be to simply disable the possibility of using the AVX functions
by manipulating our feature detecting code. Unfortunately the test->verify cycle
is huge because it requires committing the code to the deps branch, doing a deps
roll, and waiting for the xp bots to pick it up and fail. I would prefer to test
a fix.
Issue 869973003: Revert of Roll libvpx: cc9c0c:8dc6ea
(Closed)
Created 5 years, 11 months ago by binjin
Modified 5 years, 11 months ago
Reviewers: Tom Finegan, Nico, Johann
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0