Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 869973003: Revert of Roll libvpx: cc9c0c:8dc6ea (Closed)

Created:
5 years, 11 months ago by binjin
Modified:
5 years, 11 months ago
Reviewers:
Johann, Nico, Tom Finegan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll libvpx: cc9c0c:8dc6ea (patchset #3 id:40001 of https://codereview.chromium.org/845453005/) Reason for revert: Suspected to cause multiple tests failure on win vista bot http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29?numbuilds=50 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/52775 Original issue's description: > Roll libvpx: cc9c0c:8dc6ea > > Turn on AVX2 optimizations > https://codereview.chromium.org/863143002 > > Add them to GN build file: > https://codereview.chromium.org/865893004 > > Correct CPU detection: > https://codereview.chromium.org//864393002 > > Win GN build flag: > https://codereview.chromium.org//817293008 > > R=tomfinegan@chromium.org > > Committed: https://crrev.com/efd856c2a46810e742f7aba0130d534783db6b2a > Cr-Commit-Position: refs/heads/master@{#312712} TBR=tomfinegan@chromium.org,thakis@chromium.org,johannkoenig@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/8ad2a87e9d2ca440383f54a358ef294841242dca

Patch Set 1 #

Patch Set 2 : (manual) rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
binjin
Created Revert of Roll libvpx: cc9c0c:8dc6ea
5 years, 11 months ago (2015-01-23 11:14:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869973003/1
5 years, 11 months ago (2015-01-23 11:15:58 UTC) #2
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-23 11:16:40 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8ad2a87e9d2ca440383f54a358ef294841242dca Cr-Commit-Position: refs/heads/master@{#312817}
5 years, 11 months ago (2015-01-23 11:34:09 UTC) #8
binjin
Committed patchset #2 (id:40001) manually as 8ad2a87e9d2ca440383f54a358ef294841242dca (presubmit successful).
5 years, 11 months ago (2015-01-23 11:34:16 UTC) #9
Johann
Ugh, is there any way to get access to the bot, or a vista machine? ...
5 years, 11 months ago (2015-01-23 16:16:13 UTC) #10
Johann
lgtm, btw
5 years, 11 months ago (2015-01-23 16:20:40 UTC) #11
binjin
On 2015/01/23 16:16:13, Johann wrote: > Ugh, is there any way to get access to ...
5 years, 11 months ago (2015-01-23 16:53:49 UTC) #12
Johann
5 years, 11 months ago (2015-01-23 18:14:32 UTC) #13
Message was sent while issue was closed.
On 2015/01/23 16:53:49, binjin wrote:
> On 2015/01/23 16:16:13, Johann wrote:
> > Ugh, is there any way to get access to the bot, or a vista machine? The
tests
> > just time out silently. No idea what's up.
> 
> Just as Michael Achenbach's comment at
https://codereview.chromium.org/845453005
> , there are another avx change yesterday which breaks the windows xp/vista
bots
> constantly. Maybe the root causes are indeed similar?

Unfortunately the fix there appears related to whether they use AVX on the
target. Since the build appears to be passing, the next possibility is that the
AVX instructions that are generated are being run when the should not. I would
expect to see "invalid instruction" crashes in the log, not timeouts. An
experiment would be to simply disable the possibility of using the AVX functions
by manipulating our feature detecting code. Unfortunately the test->verify cycle
is huge because it requires committing the code to the deps branch, doing a deps
roll, and waiting for the xp bots to pick it up and fail. I would prefer to test
a fix.

Powered by Google App Engine
This is Rietveld 408576698