Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 845453005: Roll libvpx: cc9c0c:8dc6ea (Closed)

Created:
5 years, 11 months ago by Johann
Modified:
5 years, 11 months ago
Reviewers:
Nico, Tom Finegan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll libvpx: cc9c0c:8dc6ea Turn on AVX2 optimizations https://codereview.chromium.org/863143002 Add them to GN build file: https://codereview.chromium.org/865893004 Correct CPU detection: https://codereview.chromium.org//864393002 Win GN build flag: https://codereview.chromium.org//817293008 R=tomfinegan@chromium.org Committed: https://crrev.com/efd856c2a46810e742f7aba0130d534783db6b2a Cr-Commit-Position: refs/heads/master@{#312712}

Patch Set 1 #

Patch Set 2 : Add avx to GN build files #

Patch Set 3 : win avx flag and cpu detection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Johann
Red builds look unrelated. Some of the tests didn't appear to start correctly, or it ...
5 years, 11 months ago (2015-01-22 20:54:10 UTC) #1
Tom Finegan
On 2015/01/22 20:54:10, Johann wrote: > Red builds look unrelated. Some of the tests didn't ...
5 years, 11 months ago (2015-01-22 20:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845453005/40001
5 years, 11 months ago (2015-01-22 21:41:24 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 00:26:32 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/efd856c2a46810e742f7aba0130d534783db6b2a Cr-Commit-Position: refs/heads/master@{#312712}
5 years, 11 months ago (2015-01-23 00:27:51 UTC) #6
Nico
fyi, the avx2 stuff caused https://code.google.com/p/chromium/issues/detail?id=451290 Is avx2 active on any chips we care about?
5 years, 11 months ago (2015-01-23 02:14:34 UTC) #8
Michael Achenbach
FYI: V8 also broke the vista/xp bots with an AVX change yesterday (unrelated to this). ...
5 years, 11 months ago (2015-01-23 10:55:39 UTC) #9
binjin
5 years, 11 months ago (2015-01-23 11:14:26 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/869973003/ by binjin@chromium.org.

The reason for reverting is: Suspected to cause multiple tests failure on win
vista bot

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29?num...
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bui....

Powered by Google App Engine
This is Rietveld 408576698