Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 8698014: Switch to using the LLVM gold plugin as a fully linked-in object rather than DSO. (Closed)

Created:
9 years ago by pdox
Modified:
8 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Switch to using the LLVM gold plugin as a fully linked-in object rather than DSO. Before (text size only): ld.gold 2.5 MB libLTO.so 15.2 MB libLLVMgold.so 300 KB After: ld.gold 16 MB For comparison, clang is 33 MB, and llc is 14 MB. This creates a dependency on LLVM for binutils, which requires changing the build order to so that LLVM is built first. This will fix the DSO loading problems seen on Windows under Cygwin. There are two pre-requisite CLs: http://codereview.chromium.org/8713008/ http://codereview.chromium.org/8714005/ BUG= http://code.google.com/p/nativeclient/issues/detail?id=2286 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=7835

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -55 lines) Patch
M pnacl/build.sh View 1 2 3 4 5 6 7 8 10 chunks +53 lines, -51 lines 1 comment Download
M pnacl/driver/driver_env.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M pnacl/driver/pnacl-ar.py View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M pnacl/driver/pnacl-ld.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-nm.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-ranlib.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pdox
9 years ago (2011-11-28 05:18:44 UTC) #1
jasonwkim
On Sun, Nov 27, 2011 at 9:18 PM, <pdox@google.com> wrote: > Reviewers: krasin, robertm, nlewycky, ...
9 years ago (2011-11-28 18:28:30 UTC) #2
jasonwkim
On Mon, Nov 28, 2011 at 10:27 AM, Jason Kim <jasonwkim@google.com> wrote: > > > ...
9 years ago (2011-11-28 18:56:20 UTC) #3
pdox
yes, it does the same thing on all platforms
9 years ago (2011-11-28 19:42:50 UTC) #4
jvoung - send to chromium...
otherwise, lgtm https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (left): https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-ld.py#oldcode60 pnacl/driver/pnacl-ld.py:60: 'GOLD_PLUGIN_ARGS': '-plugin=${GOLD_PLUGIN_SO} ' + can the GOLD_PLUGIN_SO ...
8 years, 10 months ago (2012-02-18 00:10:39 UTC) #5
pdox
https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (left): https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-ld.py#oldcode60 pnacl/driver/pnacl-ld.py:60: 'GOLD_PLUGIN_ARGS': '-plugin=${GOLD_PLUGIN_SO} ' + On 2012/02/18 00:10:39, jvoung wrote: ...
8 years, 10 months ago (2012-02-18 00:15:59 UTC) #6
jvoung - send to chromium...
8 years, 6 months ago (2012-06-22 19:58:49 UTC) #7
http://codereview.chromium.org/8698014/diff/14002/pnacl/build.sh
File pnacl/build.sh (right):

http://codereview.chromium.org/8698014/diff/14002/pnacl/build.sh#newcode1265
pnacl/build.sh:1265: -o "${LLVM_GOLD_PLUGIN}"
Perhaps this shouldn't have been a single .o file (gold-plugin-static.o), but a
new static archive with libLTO + the gold-plugin.o.

Then, when we wouldn't have libLTO as a giant unit (a .o), when we build
binutils.

Powered by Google App Engine
This is Rietveld 408576698