Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 8713008: Add dlwrap.c to binutils to simulate dlopen/dlsym for gold plugin (Closed)

Created:
9 years ago by pdox
Modified:
8 years, 10 months ago
CC:
pnacl-team_google.com
Visibility:
Public.

Description

This allows us to link the gold-plugin in directly instead of using it as a DSO. This is part of change: http://codereview.chromium.org/8698014/ BUG= http://code.google.com/p/nativeclient/issues/detail?id=2286

Patch Set 1 #

Patch Set 2 : x #

Patch Set 3 : x #

Total comments: 1

Patch Set 4 : x #

Patch Set 5 : x #

Patch Set 6 : x #

Patch Set 7 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -5 lines) Patch
M binutils-2.20/bfd/Makefile.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M binutils-2.20/bfd/plugin.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M binutils-2.20/binutils/ar.c View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M binutils-2.20/gold/Makefile.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M binutils-2.20/gold/plugin.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M binutils-2.20/ld/sysdep.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A dlwrap/dlwrap.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A dlwrap/dlwrap.c View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pdox
9 years ago (2011-11-28 05:10:30 UTC) #1
robertm
I would have preferred to make the shared libs work on windows until Ivan has ...
9 years ago (2011-11-28 17:50:26 UTC) #2
pdox
I tried to keep everything well isolated. The biggest maintenance will be the configure/Makefile's, which ...
9 years ago (2011-11-28 18:10:04 UTC) #3
krasin
Is any urgency with addressing this issue (Windows bot is broken)? Why just not wait ...
9 years ago (2011-11-28 18:57:48 UTC) #4
sehr (please use chromium)
OK, I'm accepting the argument that this is a temporary hack until we can get ...
8 years, 10 months ago (2012-02-15 19:47:57 UTC) #5
pdox
This CL has been greatly simplified. PTAL.
8 years, 10 months ago (2012-02-17 22:48:14 UTC) #6
sehr (please use chromium)
8 years, 10 months ago (2012-02-17 23:19:01 UTC) #7
On 2012/02/17 22:48:14, pdox wrote:
> This CL has been greatly simplified. PTAL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698